Skip to content

Commit c9ebe29

Browse files
authored
Hero banner feedback (#79)
* Change heroBlock styles * Fix broken menu and hero height * Fix menu for tablets * Clean gcx build directory
1 parent 79d4366 commit c9ebe29

File tree

2 files changed

+30
-7
lines changed

2 files changed

+30
-7
lines changed

gcx/gulpfile.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,12 @@ const cleanTempBuild = () => {
1010
.pipe(clean());
1111
}
1212

13+
// cleans up the ui-bundle folder
14+
const cleanUiBuild = () => {
15+
return src('build/*', { read: false, allowEmpty: true })
16+
.pipe(clean());
17+
}
18+
1319
// unzips the antora ui-bundle into the tempBuild folder
1420
const unzipBundle = () => {
1521
return src('../build/ui-bundle.zip')
@@ -121,4 +127,4 @@ const cleanHeliosBuild = () => {
121127
.pipe(clean());
122128
}
123129

124-
exports.bundle = series(cleanTempBuild,unzipBundle,cleanImg,cleanHBLayouts,cleanBuild,cleanCSS,bundleCSS,bundleHeliosCSS, parallel(bundleStencil),bundleJS404, bundleJShelpers, mergeJS, cleanHighlight, bundleHB, bundleImg, zipBundle, cleanTempBuild, cleanHeliosBuild);
130+
exports.bundle = series(cleanTempBuild,cleanUiBuild,unzipBundle,cleanImg,cleanHBLayouts,cleanBuild,cleanCSS,bundleCSS,bundleHeliosCSS, parallel(bundleStencil),bundleJS404, bundleJShelpers, mergeJS, cleanHighlight, bundleHB, bundleImg, zipBundle, cleanTempBuild, cleanHeliosBuild);

gcx/styles/src/css/helios-gcx-heroBlock.css

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,15 @@
22
.dsHeroBlock[data-banner="default"] {
33
background-image: url('../img/hero-banner-1.svg');
44
background-size: cover;
5+
background-position: center;
56
color: white;
67
font-family: 'Roboto', sans-serif;
8+
padding: 1rem;
9+
height: 310px;
10+
display: flex;
11+
align-items: center;
12+
justify-content: flex-start;
13+
margin-bottom: 2rem;
714
}
815

916
.dsHeroBlock[data-banner="alternative"]{
@@ -59,16 +66,26 @@
5966

6067

6168
.dsHeroContent {
62-
padding: 72px 60px;
63-
width: 50%;
69+
width: 100%;
6470
}
6571

6672
.dsHeroTitle h1 {
6773
font-weight: 400;
6874
}
6975

70-
@media screen and (max-width: 820px) {
76+
77+
@media screen and (min-width: 1024px) {
78+
.dsHeroBlock {
79+
padding: 1rem 3rem;
80+
margin-bottom: 0;
81+
}
7182
.dsHeroContent {
72-
width: 100%;
73-
}
74-
}
83+
width: 70%;
84+
}
85+
}
86+
87+
@media screen and (min-width: 1460px) {
88+
.dsHeroContent {
89+
width: 55%;
90+
}
91+
}

0 commit comments

Comments
 (0)