DB-2993: renamed methods as per code review

Author: Stefania Alborghetti

buffer/src/main/java/io/netty/buffer/PoolArena.java

@@ -761,7 +761,7 @@ protected PoolChunk<ByteBuffer> newUnpooledChunk(int capacity) {
 
         @Override
         protected void destroyChunk(PoolChunk<ByteBuffer> chunk) {
-            PlatformDependent.freeDirectBuffer(chunk.memory);
+            PlatformDependent.freeDirect(chunk.memory);
         }
 
         @Override

buffer/src/main/java/io/netty/buffer/UnpooledDirectByteBuf.java

@@ -103,14 +103,14 @@ protected UnpooledDirectByteBuf(ByteBufAllocator alloc, ByteBuffer initialBuffer
      * Allocate a new direct {@link ByteBuffer} with the given initialCapacity.
      */
     protected ByteBuffer allocateDirect(int initialCapacity) {
-        return PlatformDependent.allocateDirectJVM(initialCapacity);
+        return PlatformDependent.allocateDirectWithCleaner(initialCapacity);
     }
 
     /**
      * Free a direct {@link ByteBuffer}
      */
     protected void freeDirect(ByteBuffer buffer) {
-        PlatformDependent.freeDirectBufferJVM(buffer);
+        PlatformDependent.freeDirectWithCleaner(buffer);
     }
 
     private void setByteBuffer(ByteBuffer buffer) {

buffer/src/main/java/io/netty/buffer/UnpooledUnsafeDirectByteBuf.java

@@ -117,14 +117,14 @@ protected UnpooledUnsafeDirectByteBuf(ByteBufAllocator alloc, ByteBuffer initial
      * Allocate a new direct {@link ByteBuffer} with the given initialCapacity.
      */
     protected ByteBuffer allocateDirect(int initialCapacity) {
-        return PlatformDependent.allocateDirectJVM(initialCapacity);
+        return PlatformDependent.allocateDirectWithCleaner(initialCapacity);
     }
 
     /**
      * Free a direct {@link ByteBuffer}
      */
     protected void freeDirect(ByteBuffer buffer) {
-        PlatformDependent.freeDirectBufferJVM(buffer);
+        PlatformDependent.freeDirectWithCleaner(buffer);
     }
 
     final void setByteBuffer(ByteBuffer buffer, boolean tryFree) {

common/src/main/java/io/netty/util/internal/PlatformDependent.java

@@ -574,22 +574,22 @@ public static void setMemory(long address, long bytes, byte value) {
     public static ByteBuffer allocateDirect(int capacity) {
         return USE_DIRECT_BUFFER_NO_CLEANER
                 ? PlatformDependent.allocateDirectNoCleaner(capacity)
-                : allocateDirectJVM(capacity);
+                : allocateDirectWithCleaner(capacity);
     }
 
-    public static void freeDirectBuffer(ByteBuffer buffer) {
+    public static void freeDirect(ByteBuffer buffer) {
         if (USE_DIRECT_BUFFER_NO_CLEANER) {
             PlatformDependent.freeDirectNoCleaner(buffer);
         } else {
-            PlatformDependent.freeDirectBufferJVM(buffer);
+            PlatformDependent.freeDirectWithCleaner(buffer);
         }
     }
 
     /**
      * Allocate a new {@link ByteBuffer} with the given {@code capacity}. {@link ByteBuffer}s allocated with
-     * this method <strong>MUST</strong> be deallocated via {@link #freeDirectNoCleaner(ByteBuffer)}.
+     * this method <strong>MUST</strong> be deallocated via {@link #freeDirectWithCleaner(ByteBuffer)}.
      */
-    public static ByteBuffer allocateDirectJVM(int capacity) {
+    public static ByteBuffer allocateDirectWithCleaner(int capacity) {
         incrementMemoryCounter(capacity);
         try {
             return ByteBuffer.allocateDirect(capacity);
@@ -604,7 +604,7 @@ public static ByteBuffer allocateDirectJVM(int capacity) {
      * Try to deallocate the specified direct {@link ByteBuffer}. Please note this method does nothing if
      * the current platform does not support this operation or the specified buffer is not a direct buffer.
      */
-    public static void freeDirectBufferJVM(ByteBuffer buffer) {
+    public static void freeDirectWithCleaner(ByteBuffer buffer) {
         int capacity = buffer.capacity();
         CLEANER.freeDirectBuffer(buffer);
         decrementMemoryCounter(capacity);

microbench/src/main/java/io/netty/microbench/handler/ssl/AbstractSslEngineBenchmark.java

@@ -109,12 +109,12 @@ ByteBuffer newBuffer(int size) {
         DIRECT {
             @Override
             ByteBuffer newBuffer(int size) {
-                return PlatformDependent.allocateDirectJVM(size);
+                return PlatformDependent.allocateDirectWithCleaner(size);
             }
 
             @Override
             void freeBuffer(ByteBuffer buffer) {
-                PlatformDependent.freeDirectBufferJVM(buffer);
+                PlatformDependent.freeDirectWithCleaner(buffer);
             }
         };