Skip to content

Commit df9ad00

Browse files
carbribicarbribi
authored andcommitted
Revised based on feedback from Velvia. Added note to make a clarification on yarn page.
1 parent 5d7a35c commit df9ad00

File tree

3 files changed

+10
-11
lines changed

3 files changed

+10
-11
lines changed

doc/yarn.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,6 +4,8 @@
44

55
(I would like to thank Jon Buffington for sharing the config tips below.... @velvia)
66

7+
Note: This is for yarn with docker. If you are looking to deploy on a yarn cluster via EMR, then this link would be more useful [EMR](https://github.com/spark-jobserver/spark-jobserver/blob/master/doc/EMR.md)
8+
79
### Configuring the Spark-Jobserver Docker package to run in Yarn-Client Mode
810

911
To run the Spark-Jobserver in yarn-client mode you have to do a little bit extra of configuration.

job-server-extras/src/spark.jobserver/NamedBroadcast.scala

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,6 @@ case class NamedBroadcast[T](broadcast: Broadcast[T]) extends NamedObject
1212
*/
1313
class BroadcastPersister[T] extends NamedObjectPersister[NamedBroadcast[T]] {
1414
override def persist(namedObj: NamedBroadcast[T], name: String) {
15-
namedObj match {
16-
case NamedBroadcast(broadcast) =>{}
17-
}
1815
}
1916
override def unpersist(namedObj: NamedBroadcast[T]) {
2017
namedObj match {

job-server-extras/test/spark.jobserver/NamedObjectsJobSpec.scala

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ class NamedObjectsJobSpec extends JobSpecBase(JobManagerSpec.getNewSystem) {
2828

2929
val jobName = "spark.jobserver.NamedObjectsTestJob"
3030

31-
private def getCreateConfig(createDF: Boolean, createRDD: Boolean, createBroadcast: Boolean) : Config = {
32-
ConfigFactory.parseString("spark.jobserver.named-object-creation-timeout = 60 s, " +
31+
private def getCreateConfig(createDF: Boolean, createRDD: Boolean, createBroadcast: Boolean = false) : Config = {
32+
ConfigFactory.parseString("spark.jobserver.named-object-creation-timeout = 60 s, " +
3333
NamedObjectsTestJobConfig.CREATE_DF + " = " + createDF + ", " +
3434
NamedObjectsTestJobConfig.CREATE_RDD + " = " + createRDD + ", " +
3535
NamedObjectsTestJobConfig.CREATE_BROADCAST + " = " + createBroadcast)
@@ -43,11 +43,11 @@ class NamedObjectsJobSpec extends JobSpecBase(JobManagerSpec.getNewSystem) {
4343
describe("NamedObjects (RDD)") {
4444
it("should survive from one job to another one") {
4545

46-
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, true, false), errorEvents ++ syncEvents)
46+
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, true), errorEvents ++ syncEvents)
4747
val JobResult(_, names: Array[String]) = expectMsgClass(classOf[JobResult])
4848
names should contain("rdd1")
4949

50-
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, false, false), errorEvents ++ syncEvents)
50+
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, false), errorEvents ++ syncEvents)
5151
val JobResult(_, names2: Array[String]) = expectMsgClass(classOf[JobResult])
5252

5353
names2 should contain("rdd1")
@@ -65,12 +65,12 @@ class NamedObjectsJobSpec extends JobSpecBase(JobManagerSpec.getNewSystem) {
6565
describe("NamedObjects (DataFrame)") {
6666
it("should survive from one job to another one") {
6767

68-
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(true, false, false), errorEvents ++ syncEvents)
68+
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(true, false), errorEvents ++ syncEvents)
6969
val JobResult(_, names: Array[String]) = expectMsgClass(classOf[JobResult])
7070

7171
names should contain("df1")
7272

73-
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, false, false), errorEvents ++ syncEvents)
73+
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, false), errorEvents ++ syncEvents)
7474
val JobResult(_, names2: Array[String]) = expectMsgClass(classOf[JobResult])
7575

7676
names2 should equal(names)
@@ -84,13 +84,13 @@ class NamedObjectsJobSpec extends JobSpecBase(JobManagerSpec.getNewSystem) {
8484
describe("NamedObjects (DataFrame + RDD)") {
8585
it("should survive from one job to another one") {
8686

87-
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(true, true, false), errorEvents ++ syncEvents)
87+
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(true, true), errorEvents ++ syncEvents)
8888
val JobResult(_, names: Array[String]) = expectMsgClass(classOf[JobResult])
8989

9090
names should contain("rdd1")
9191
names should contain("df1")
9292

93-
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, false, false), errorEvents ++ syncEvents)
93+
manager ! JobManagerActor.StartJob("demo", jobName, getCreateConfig(false, false), errorEvents ++ syncEvents)
9494
val JobResult(_, names2: Array[String]) = expectMsgClass(classOf[JobResult])
9595

9696
names2 should equal(names)

0 commit comments

Comments
 (0)