Add requirement python3-tomli

[karaketir16]

python3-tomli required for build-sim SIM=qemu in Ubuntu 22.04, I did not try other operating systems. fix #1615

[TommyMurphyTM1234]

python3-tomli required for build-sim SIM=qemu in Ubuntu 22.04, I did not try other operating systems.

Why wouldn't this have triggered a problem here?

• riscv-gnu-toolchain/.github/workflows/nightly-release.yaml

  Lines 87 to 90 in 444c01e

  	- name: build qemu
  	if: ${{ matrix.mode }} == 'linux'
  	run: |
  	sudo make -j$(nproc) build-sim SIM=qemu

when this package isn't part of the prerequisites installation script?

• riscv-gnu-toolchain/.github/setup-apt.sh

  Lines 6 to 9 in 444c01e

  	apt install -y autoconf automake autotools-dev curl python3 python3-pip libmpc-dev libmpfr-dev \
  	libgmp-dev gawk build-essential bison flex texinfo gperf libtool \
  	patchutils bc zlib1g-dev libexpat-dev git ninja-build cmake libglib2.0-dev expect \
  	device-tree-compiler python3-pyelftools libslirp-dev

[karaketir16]

If I understand correctly, you are using a GitHub Ubuntu Image, that has pre-installed tools.

https://github.com/actions/runner-images/blob/ubuntu22/20241015.1/images/ubuntu/Ubuntu2204-Readme.md

But, I cannot found tomli in the list.

[karaketir16]

The error is added with this patch.

https://patchwork.kernel.org/project/qemu-devel/patch/[email protected]/

[karaketir16]

I have checked.

https://github.com/karaketir16/test-workflows/actions/runs/11853849709/job/33034785384#step:4:1

GitHub Runner Ubuntu 22.04 image has tomli

[mickflemm]

I ran this a few days back on a fresh ubuntu 22.04 container from the LXD repo and I didn't have to install tomli, the build script of QEMU uses a python venv and installs needed packages itself.

[TommyMurphyTM1234]

I ran this a few days back on a fresh ubuntu 22.04 container from the LXD repo and I didn't have to install tomli, the build script of QEMU uses a python venv and installs needed packages itself.

Does that mean that this issue/PR is moot and no change is needed?

[mickflemm]

Nope it was my mistake, I installed QEMU 8.2 that used a bundled version of tomli for fallback when building its venv. Since 9.2 systems with python < 3.10, such as 22.04, require tomli to be installed (recent python versions include this already, so for example it's not a requirement for 24.04, for more infos check out #1615.

…

On Sun, Dec 15, 2024 at 7:54 PM Tommy Murphy ***@***.***> wrote: I ran this a few days back on a fresh ubuntu 22.04 container from the LXD repo and I didn't have to install tomli, the build script of QEMU uses a python venv and installs needed packages itself. Does that mean that this issue/PR is moot and no change is needed? — Reply to this email directly, view it on GitHub <#1614 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADRMHJKRVS6MOAP6EYQWMT2FWQ3FAVCNFSM6AAAAABRZ32EE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHEZDMMRRGA> . You are receiving this because you commented.Message ID: ***@***.***>

-- GPG ID: 0xEE878588 As you read this post global entropy rises. Have Fun ;-) Nick

[TommyMurphyTM1234]

Nope it was my mistake, I installed QEMU 8.2 that used a bundled version of tomli for fallback when building its venv. Since 9.2 systems with python < 3.10, such as 22.04, require tomli to be installed (recent python versions include this already, so for example it's not a requirement for 24.04, for more infos check out #1615.
…
On Sun, Dec 15, 2024 at 7:54 PM Tommy Murphy @.> wrote: I ran this a few days back on a fresh ubuntu 22.04 container from the LXD repo and I didn't have to install tomli, the build script of QEMU uses a python venv and installs needed packages itself. Does that mean that this issue/PR is moot and no change is needed? — Reply to this email directly, view it on GitHub <#1614 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADRMHJKRVS6MOAP6EYQWMT2FWQ3FAVCNFSM6AAAAABRZ32EE2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNBTHEZDMMRRGA . You are receiving this because you commented.Message ID: @.>
-- GPG ID: 0xEE878588 As you read this post global entropy rises. Have Fun ;-) Nick

Thanks @mickflemm - so this PR should be merged then?

[cmuellner]

Please also add the package to https://github.com/riscv-collab/riscv-gnu-toolchain/blob/master/.github/setup-apt.sh.

If it is there as well, we can merge this.

[cmuellner]

LGTM

[cmuellner]

Thanks!