Skip to content

Commit 05f991d

Browse files
authored
Merge pull request #51 from topperc/patch-1
Grammar fixes to target ISA section
2 parents 3e7dc6b + ada8b2d commit 05f991d

File tree

1 file changed

+8
-10
lines changed

1 file changed

+8
-10
lines changed

README.mkd

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -62,12 +62,12 @@ Chapter `ISA Extension Naming Conventions` of the RISC-V user-level ISA
6262
specification. However, tools do not currently follow this specification
6363
(input is case sensitive, ...).
6464

65-
The rule of ISA string become more complicated, due to extensions implication
66-
rule and more extensions added into RISC-V, the canonical order is non-obvious
67-
to human, so tools can accept the ISA string in non-canonical order for reduce
65+
The rule of ISA string become more complicated, due to extension implication
66+
rules and more extensions added into RISC-V, the canonical order is non-obvious
67+
to humans, so tools should accept the ISA string in non-canonical order to reduce
6868
the burden of remembering the canonical order.
6969

70-
Detail rule for ISA string:
70+
Detailed rules for ISA string:
7171

7272
1. First letter must be `i`, `e` or `g`.
7373
2. Single-letter may be non-canonical order.
@@ -93,13 +93,13 @@ rv32i2p1 # Valid ISA string, it recognized as `I` extension with
9393
If the 'C' (compressed) instruction set extension is targeted, the compiler
9494
will generate compressed instructions where possible.
9595

96-
NOTE: Single-letter extension with version (e.g. `m2p0`) still treat as
97-
single-letter extension, we won't treat it as multi-letter extension.
96+
NOTE: Single-letter extension with version (e.g. `m2p0`) is still treated as
97+
a single-letter extension, it won't be treated as a multi-letter extension.
9898

9999
NOTE: Any output of ISA string like `Tag_RISCV_arch` must be canonical order.
100100

101-
NOTE: Cross-tool argument are highly recommended passed in canonical order for
102-
backward compatible.
101+
NOTE: Cross-tool argument are highly recommended to be passed in canonical order
102+
for backward compatibility.
103103

104104
### Issues for consideration
105105
* Whether `riscv32` and `riscv64` should be accepted as synonyms for `rv32`
@@ -109,8 +109,6 @@ and `rv64`.
109109
* Specifying non-standard extensions. The ISA specification suggests naming
110110
such as `rv32gXfirstext_Xsecondext`. In GCC or Clang it would be more
111111
conventional to give a string such as `rv32g+firstext+secondext`.
112-
* Whether ordering should be enforced on the ISA string (e.g. currently
113-
`rv32imafd` is accepted by GCC but `rv32iamfd` is not).
114112

115113
## Specifying the target ABI with -mabi
116114

0 commit comments

Comments
 (0)