Skip to content

Commit 33d9896

Browse files
committed
[NFC] Simplify git commit targets
Signed-off-by: Jerry Zhang Jian <[email protected]>
1 parent 94ef2aa commit 33d9896

File tree

1 file changed

+41
-47
lines changed

1 file changed

+41
-47
lines changed

rvv-intrinsic-generator/Makefile

Lines changed: 41 additions & 47 deletions
Original file line numberDiff line numberDiff line change
@@ -325,56 +325,50 @@ gen-all:
325325
rm -rf ${DIR}
326326
make all OUTPUT_DIR=${OUTPUT_DIR}
327327

328-
# Update and commit all files under auto-generated
329-
git-commit-all:
330-
make git-commit-autogen-doc OUTPUT_DIR=${OUTPUT_DIR}
331-
make git-commit-autogen-test OUTPUT_DIR=${OUTPUT_DIR}
332-
333-
git-commit-bf16-all:
334-
make git-commit-autogen-bf16-doc OUTPUT_DIR=${OUTPUT_DIR}
335-
make git-commit-autogen-bf16-test OUTPUT_DIR=${OUTPUT_DIR}
336-
337-
git-commit-vector-crypto-all:
338-
make git-commit-autogen-vector-crypto-doc OUTPUT_DIR=${OUTPUT_DIR}
339-
make git-commit-autogen-vector-crypto-test OUTPUT_DIR=${OUTPUT_DIR}
340-
341-
# Update and commit all documents under auto-generated
342-
git-commit-autogen-doc:
343-
make gen-document OUTPUT_DIR=${OUTPUT_DIR}
344-
git add ${DIR}/*
345-
git commit -m "[Auto-gen] Update documents under ${OUTPUT_DIR}. (make git-commit-autogen-doc)"
346-
347-
git-commit-autogen-bf16-doc:
348-
make gen-bf16-document OUTPUT_DIR=${OUTPUT_DIR}
349-
git add ${BF16_DIR}/*
350-
git commit -m "[Auto-gen] Update bfloat16 documents under ${OUTPUT_DIR}. (make git-commit-autogen-bf16-doc)"
351-
352-
git-commit-autogen-vector-crypto-doc:
353-
make gen-vector-crypto-document OUTPUT_DIR=${OUTPUT_DIR}
354-
git add ${VECTOR_CRYPTO_DIR}/*
355-
git commit -m "[Auto-gen] Update vector crypto documents under ${OUTPUT_DIR}. (make git-commit-autogen-vector-crypto-doc)"
356-
357-
# Update and commit all testing C source files under auto-generated
358-
git-commit-autogen-test:
359-
make gen-test
360-
git add ${DIR}/*
361-
git commit -m "[Auto-gen] Update tests under ${OUTPUT_DIR}. (make git-commit-autogen-test)"
362-
363-
git-commit-autogen-bf16-test:
364-
make gen-bf16-test
365-
git add ${BF16_DIR}/*
366-
git commit -m "[Auto-gen] Update bfloat16 tests under ${OUTPUT_DIR}. (make git-commit-autogen-bf16-test)"
367-
368-
git-commit-autogen-vector-crypto-test:
369-
make gen-vector-crypto-test
370-
git add ${VECTOR_CRYPTO_DIR}/*
371-
git commit -m "[Auto-gen] Update vector crypto tests under ${OUTPUT_DIR}. (make git-commit-autogen-vector-crypto-test)"
372-
373-
# Update and commit compatible headers under auto-generated
328+
# Define common variables
329+
TYPES = default bf16 vector-crypto
330+
DIR_default = ${DIR}
331+
DIR_bf16 = ${BF16_DIR}
332+
DIR_vector-crypto = ${VECTOR_CRYPTO_DIR}
333+
COMMIT_MSG_PREFIX = [Auto-gen]
334+
335+
# Generic update and commit target for docs
336+
git-commit-autogen-%-doc:
337+
$(eval TYPE=$(patsubst git-commit-autogen-%-doc,%,$@))
338+
$(eval DIR_VAR=$(if $(filter default,$(TYPE)),DIR,DIR_$(TYPE)))
339+
$(eval GEN_CMD=$(if $(filter default,$(TYPE)),gen-document,gen-$(TYPE)-document))
340+
$(eval TYPE_DESC=$(if $(filter default,$(TYPE)),,$(TYPE) ))
341+
make $(GEN_CMD) OUTPUT_DIR=${OUTPUT_DIR}
342+
git add ${$(DIR_VAR)}/*
343+
git commit -m "$(COMMIT_MSG_PREFIX) Update $(TYPE_DESC)documents under ${OUTPUT_DIR}. (make $@)"
344+
345+
# Generic update and commit target for tests
346+
git-commit-autogen-%-test:
347+
$(eval TYPE=$(patsubst git-commit-autogen-%-test,%,$@))
348+
$(eval DIR_VAR=$(if $(filter default,$(TYPE)),DIR,DIR_$(TYPE)))
349+
$(eval GEN_CMD=$(if $(filter default,$(TYPE)),gen-test,gen-$(TYPE)-test))
350+
$(eval TYPE_DESC=$(if $(filter default,$(TYPE)),,$(TYPE) ))
351+
make $(GEN_CMD)
352+
git add ${$(DIR_VAR)}/*
353+
git commit -m "$(COMMIT_MSG_PREFIX) Update $(TYPE_DESC)tests under ${OUTPUT_DIR}. (make $@)"
354+
355+
# Update and commit both docs and tests for each type
356+
git-commit-%-all:
357+
$(eval TYPE=$(patsubst git-commit-%-all,%,$@))
358+
$(eval TYPE_PREFIX=$(if $(filter default,$(TYPE)),,$(TYPE)-))
359+
make git-commit-autogen-$(TYPE_PREFIX)doc OUTPUT_DIR=${OUTPUT_DIR}
360+
make git-commit-autogen-$(TYPE_PREFIX)test OUTPUT_DIR=${OUTPUT_DIR}
361+
362+
# Provide backward compatibility aliases
363+
git-commit-all: git-commit-default-all
364+
git-commit-autogen-doc: git-commit-autogen-default-doc
365+
git-commit-autogen-test: git-commit-autogen-default-test
366+
367+
# Update and commit compatible headers (kept as-is since it doesn't follow the pattern)
374368
git-commit-autogen-compatible-header:
375369
make gen-compatible-header
376370
git add $(DIR)/*
377-
git commit -m "[Auto-gen] Update tests under ${OUTPUT_DIR}. (make git-commmit-autogen-compatible-header)"
371+
git commit -m "$(COMMIT_MSG_PREFIX) Update tests under ${OUTPUT_DIR}. (make git-commit-autogen-compatible-header)"
378372

379373
# Runs diff with auto-generated, requires ${TEST_DIR} to be provided.
380374
GOLDEN_DIR = ${DIR}

0 commit comments

Comments
 (0)