Skip to content

Commit 0396da3

Browse files
committed
fix: skip fence.tso on llvm-test since compiler and ISA view of instruction differ
fence.tso is a fence instruction and the ISA states it shall be all zeros. Compilers like LLVM take this literally and only implement it all constant, while the ISA leaves some fields open to newer implementation approaches. When we check UDB version that refers to the ISA vs LLVM, the test fails because of the different view on the subject. Ad-hoc skip the LLVM test for fence.tso. Signed-off-by: Afonso Oliveira <[email protected]>
1 parent 802a8e7 commit 0396da3

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

ext/auto-inst/test_parsing.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -122,6 +122,7 @@ def test_instruction_encoding(self, instr_name):
122122
or instr_name == "c.nop"
123123
or instr_name == "fcvtmod.w.d"
124124
or instr_name == "fence"
125+
or instr_name == "fence.tso"
125126
):
126127
pytest.skip(
127128
f"Instruction {instr_name} is a corner case and implementation should not follow ISA spec"

0 commit comments

Comments
 (0)