add shell script fmt and lint with pre-commit checks and fix errors (#500)

fixes #495
relates to #493, #494

Author: kbroch-rivosinc

.pre-commit-config.yaml

@@ -23,14 +23,14 @@ repos:
       - id: check-yaml
 
   - repo: https://github.com/rbubley/mirrors-prettier
-    rev: v3.4.2
+    rev: v3.5.3
     hooks:
       - id: prettier
         files: \.(json|yml|yaml)$
         exclude: schemas/json-schema-draft-07.json
 
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: 0.30.0
+    rev: 0.31.3
     hooks:
       - id: check-jsonschema
         alias: check-jsonschema-inst
@@ -59,11 +59,26 @@ repos:
       #   args: ["--schemafile", "schemas/manual_version_schema.json"]
 
   - repo: https://github.com/psf/black-pre-commit-mirror
-    rev: 24.8.0
+    rev: 25.1.0
     hooks:
       - id: black
 
   - repo: https://github.com/asottile/pyupgrade
     rev: v3.19.1
     hooks:
       - id: pyupgrade
+
+  - repo: https://github.com/koalaman/shellcheck-precommit
+    rev: v0.10.0
+    hooks:
+      - id: shellcheck
+        args: ["--severity=error"]
+
+  - repo: https://github.com/scop/pre-commit-shfmt
+    rev: v3.11.0-1
+    hooks:
+      - id: shfmt
+        args:
+          - --indent
+          - "2"
+          - --case-indent

bin/asciidoctor

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(dirname $(realpath $BASH_SOURCE[0]))
+ROOT=$(dirname $(realpath ${BASH_SOURCE[0]}))
 source $ROOT/setup
 
 $BUNDLE exec --gemfile $ROOT/Gemfile asciidoctor "$@"

bin/bash

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(dirname $(realpath $BASH_SOURCE[0]))
+ROOT=$(dirname $(realpath ${BASH_SOURCE[0]}))
 source $ROOT/setup
 
 $BASH "$@"

bin/build_container

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(realpath $(dirname $(dirname $BASH_SOURCE[0])))
+ROOT=$(realpath $(dirname $(dirname ${BASH_SOURCE[0]})))
 
 CONTAINER_TAG=`cat ${ROOT}/bin/.container-tag`
 

bin/bundle

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(dirname $(realpath $BASH_SOURCE[0]))
+ROOT=$(dirname $(realpath ${BASH_SOURCE[0]}))
 source $ROOT/setup
 
 $BUNDLE "$@"

bin/clean

@@ -1,5 +1,5 @@
 #!/bin/bash
 
-ROOT=$(dirname $(dirname $(realpath $BASH_SOURCE[0])))
+ROOT=$(dirname $(dirname $(realpath ${BASH_SOURCE[0]})))
 
 rm -rf ${ROOT}/.stamps ${ROOT}/.home ${ROOT}/.bundle ${ROOT}/.singularity ${ROOT}/gen ${ROOT}/node_modules

bin/node

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(dirname $(realpath $BASH_SOURCE[0]))
+ROOT=$(dirname $(realpath ${BASH_SOURCE[0]}))
 source $ROOT/setup
 
 $NODE "$@"

bin/npx

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(dirname $(realpath $BASH_SOURCE[0]))
+ROOT=$(dirname $(realpath ${BASH_SOURCE[0]}))
 source $ROOT/setup
 
 $NPX "$@"

bin/pip

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(dirname $(realpath $BASH_SOURCE[0]))
+ROOT=$(dirname $(realpath ${BASH_SOURCE[0]}))
 source $ROOT/setup
 
 if [ ! -v VIRTUAL_ENV ]; then

bin/pre-commit

@@ -1,6 +1,6 @@
 #!/bin/bash
 
-ROOT=$(dirname $(dirname $(realpath $BASH_SOURCE[0])))
+ROOT=$(dirname $(dirname $(realpath ${BASH_SOURCE[0]})))
 source $ROOT/bin/setup
 
 $PYTHON -mpre_commit "$@"