Skip to content

Commit 8721e67

Browse files
Merge pull request #306 from riscv-software-src/303-add-missing-recommendations-to-profiles
Just need to add to RVA22 (already in RVA20). Also changed to bullet list for each separate recommendation.
2 parents daeadcf + 230d84f commit 8721e67

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed

arch/profile_release/RVA22.yaml

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,6 +156,10 @@ RVA22:
156156
text: |
157157
The Zfinx, Zdinx, Zhinx, Zhinxmin extensions are incompatible
158158
with the profile mandates to support the F and D extensions.
159+
recommendations:
160+
- text: |
161+
Implementations are strongly recommended to raise illegal-instruction
162+
exceptions on attempts to execute unimplemented opcodes.
159163
RVA22S64:
160164
marketing_name: RVA22S64
161165
mode: S
@@ -257,4 +261,8 @@ RVA22:
257261
* Shvstvala
258262
* Shtvala
259263
* Shvstvecd
260-
* Shgatpa
264+
* Shgatpa
265+
recommendations:
266+
- text: |
267+
Implementations are strongly recommended to raise illegal-instruction
268+
exceptions on attempts to execute unimplemented opcodes.

backends/profile_doc/templates/profile.adoc.erb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -390,7 +390,7 @@ associated implementation-defined parameters across all its defined profiles.
390390
Recommendations are not strictly mandated but are included to guide implementers making design choices.
391391
392392
<% profile.recommendations.each do |recommendation| -%>
393-
<%= recommendation.text %>
393+
* <%= recommendation.text %>
394394
<% end # each recommendation -%>
395395
<% end # unless recommendations empty -%>
396396

0 commit comments

Comments
 (0)