Merge branch 'main' into merge-before-isolation

Signed-off-by: james-ball-qualcomm <[email protected]>

Author: james-ball-qualcomm

.devcontainer/Dockerfile

@@ -6,26 +6,35 @@ WORKDIR /workspace
 
 RUN export DEBIAN_FRONTEND=noninteractive
 RUN apt-get update
-RUN apt-get install -y --no-install-recommends git \
-                                               gh \
-                                               less \
-                                               python3 \
-                                               python3.12-venv \
-                                               python3-pip \
-                                               build-essential \
-                                               ruby \
-                                               ruby-dev \
-                                               bundler \
-                                               nodejs \
-                                               npm \
-                                               ditaa \
-                                               libyaml-dev \
-                                               cmake \
-                                               g++ \
-                                               clang-format \
-                                               clang-tidy \
-                                               libelf-dev \
-                                               gcc-riscv64-unknown-elf
+
+# please keep pkgs sorted
+RUN apt-get install -y --no-install-recommends \
+    build-essential \
+    bundler \
+    clang-format \
+    clang-tidy \
+    cmake \
+    ditaa \
+    g++ \
+    gcc-riscv64-linux-gnu \
+    gcc-riscv64-unknown-elf \
+    gdb \
+    gh \
+    git \
+    less \
+    libc6-dev-riscv64-cross \
+    libelf-dev \
+    libgmp-dev \
+    libyaml-dev \
+    nodejs \
+    npm \
+    python3 \
+    python3-pip \
+    python3.12-venv \
+    ruby \
+    ruby-dev \
+    shellcheck
+
 RUN apt-get clean autoclean
 RUN apt-get autoremove -y
 RUN rm -rf /var/lib/{apt,dpkg,cache,log}/*

.github/workflows/regress.yml

@@ -191,3 +191,31 @@ jobs:
         run: ./bin/build_container
       - name: Generate extension PDF
         run: ./do gen:profile_release_pdf[Mock]
+  regress-gen-go:
+    runs-on: ubuntu-latest
+    env:
+      SINGULARITY: 1
+    steps:
+      - name: Clone Github Repo Action
+        uses: actions/checkout@v4
+      - name: Setup apptainer
+        uses: eWaterCycle/[email protected]
+      - name: Get container from cache
+        id: cache-sif
+        uses: actions/cache@v4
+        with:
+          path: .singularity/image.sif
+          key: ${{ hashFiles('container.def', 'bin/.container-tag') }}
+      - name: Get gems and node files from cache
+        id: cache-bundle-npm
+        uses: actions/cache@v4
+        with:
+          path: |
+            .home/.gems
+            node_modules
+          key: ${{ hashFiles('Gemfile.lock') }}-${{ hashFiles('package-lock.json') }}
+      - if: ${{ steps.cache-sif.outputs.cache-hit != 'true' }}
+        name: Build container
+        run: ./bin/build_container
+      - name: Generate Go code
+        run: ./do gen:go

.pre-commit-config.yaml

@@ -30,7 +30,7 @@ repos:
         exclude: schemas/json-schema-draft-07.json
 
   - repo: https://github.com/python-jsonschema/check-jsonschema
-    rev: 0.31.3
+    rev: 0.32.1
     hooks:
       - id: check-jsonschema
         alias: check-jsonschema-inst
@@ -59,7 +59,7 @@ repos:
       #   args: ["--schemafile", "schemas/manual_version_schema.json"]
 
   - repo: https://github.com/pre-commit/mirrors-clang-format
-    rev: "v18.1.3"
+    rev: "v20.1.0"
     hooks:
       - id: clang-format
         types_or: [c++, c]
@@ -74,11 +74,14 @@ repos:
     hooks:
       - id: pyupgrade
 
-  # - repo: https://github.com/koalaman/shellcheck-precommit
-  #   rev: v0.10.0
-  #   hooks:
-  #     - id: shellcheck
-  #       args: ["--severity=error"]
+  - repo: local
+    hooks:
+      - id: shellcheck
+        name: shellcheck
+        types: [shell]
+        language: system
+        entry: shellcheck
+        args: ["--severity=error"]
 
   - repo: https://github.com/scop/pre-commit-shfmt
     rev: v3.11.0-1

Rakefile

@@ -468,8 +468,10 @@ namespace :test do
     puts "UPDATE: Generating MockProfileRelease.pdf"
     Rake::Task["#{$root}/gen/profile/pdf/MockProfileRelease.pdf"].invoke
 
+    puts "UPDATE: Generating Go Language Support"
+    Rake::Task["gen:go"].invoke
+
     puts "UPDATE: Done test:regress"
-    puts "Regression test PASSED"
   end
 
   desc <<~DESC

arch/inst/A/amoadd.d.yaml

@@ -44,6 +44,9 @@ operation(): |
 
   X[rd] = amo<64>(virtual_address, X[rs2], AmoOperation::Add, aq, rl, $encoding);
 
+# SPDX-SnippetBegin
+# SPDX-FileCopyrightText: 2017-2025 Contributors to the RISCV Sail Model <https://github.com/riscv/sail-riscv/blob/master/LICENCE>
+# SPDX-License-Identifier: BSD-2-Clause
 sail(): |
   {
     if extension("A") then {
@@ -134,3 +137,5 @@ sail(): |
       RETIRE_FAIL
     }
   }
+
+# SPDX-SnippetEnd

arch/inst/A/amoadd.w.yaml

@@ -43,6 +43,9 @@ operation(): |
 
   X[rd] = amo<32>(virtual_address, X[rs2][31:0], AmoOperation::Add, aq, rl, $encoding);
 
+# SPDX-SnippetBegin
+# SPDX-FileCopyrightText: 2017-2025 Contributors to the RISCV Sail Model <https://github.com/riscv/sail-riscv/blob/master/LICENCE>
+# SPDX-License-Identifier: BSD-2-Clause
 sail(): |
   {
     if extension("A") then {
@@ -133,3 +136,5 @@ sail(): |
       RETIRE_FAIL
     }
   }
+
+# SPDX-SnippetEnd

arch/inst/A/amoand.d.yaml

@@ -44,6 +44,9 @@ operation(): |
 
   X[rd] = amo<64>(virtual_address, X[rs2], AmoOperation::And, aq, rl, $encoding);
 
+# SPDX-SnippetBegin
+# SPDX-FileCopyrightText: 2017-2025 Contributors to the RISCV Sail Model <https://github.com/riscv/sail-riscv/blob/master/LICENCE>
+# SPDX-License-Identifier: BSD-2-Clause
 sail(): |
   {
     if extension("A") then {
@@ -134,3 +137,5 @@ sail(): |
       RETIRE_FAIL
     }
   }
+
+# SPDX-SnippetEnd

arch/inst/A/amoand.w.yaml

@@ -43,6 +43,9 @@ operation(): |
 
   X[rd] = amo<32>(virtual_address, X[rs2][31:0], AmoOperation::And, aq, rl, $encoding);
 
+# SPDX-SnippetBegin
+# SPDX-FileCopyrightText: 2017-2025 Contributors to the RISCV Sail Model <https://github.com/riscv/sail-riscv/blob/master/LICENCE>
+# SPDX-License-Identifier: BSD-2-Clause
 sail(): |
   {
     if extension("A") then {
@@ -133,3 +136,5 @@ sail(): |
       RETIRE_FAIL
     }
   }
+
+# SPDX-SnippetEnd

arch/inst/A/amomax.d.yaml

@@ -44,6 +44,9 @@ operation(): |
 
   X[rd] = amo<64>(virtual_address, X[rs2], AmoOperation::Max, aq, rl, $encoding);
 
+# SPDX-SnippetBegin
+# SPDX-FileCopyrightText: 2017-2025 Contributors to the RISCV Sail Model <https://github.com/riscv/sail-riscv/blob/master/LICENCE>
+# SPDX-License-Identifier: BSD-2-Clause
 sail(): |
   {
     if extension("A") then {
@@ -134,3 +137,5 @@ sail(): |
       RETIRE_FAIL
     }
   }
+
+# SPDX-SnippetEnd

arch/inst/A/amomax.w.yaml

@@ -43,6 +43,9 @@ operation(): |
 
   X[rd] = amo<32>(virtual_address, X[rs2][31:0], AmoOperation::Max, aq, rl, $encoding);
 
+# SPDX-SnippetBegin
+# SPDX-FileCopyrightText: 2017-2025 Contributors to the RISCV Sail Model <https://github.com/riscv/sail-riscv/blob/master/LICENCE>
+# SPDX-License-Identifier: BSD-2-Clause
 sail(): |
   {
     if extension("A") then {
@@ -133,3 +136,5 @@ sail(): |
       RETIRE_FAIL
     }
   }
+
+# SPDX-SnippetEnd