fixed idl op for Zbkb

Author: Jennifer Dupaquier

arch/inst/Zbkb/brev8.yaml

@@ -27,6 +27,18 @@ operation(): |
     raise (ExceptionCode::IllegalInstruction, mode(), $encoding);
   }
 
+  XReg input = X[rs1];
+  XReg output = 0;
+
+  for(U32 i=0; i<(xlen()-8); i = i+8) {
+    for(U32 j=0; j<8; j = j+1) {
+      output[(i*8)+(7-j)] = input[(i*8)+j];
+    }
+  }
+
+  X[rd] = output;
+
+sail(): |
   result : xlenbits = EXTZ(0b0);
   foreach (i from 0 to sizeof(xlen) by 8) {
     result[i+7..i] = reverse_bits_in_byte(X(rs1)[i+7..i]);

arch/inst/Zbkb/unzip.yaml

@@ -30,7 +30,20 @@ operation(): |
     raise (ExceptionCode::IllegalInstruction, mode(), $encoding);
   }
 
+  XReg input = X[rs1];
+  XReg output = 0;
+
+  for(U32 i=0; i<(xlen()/2-1); i = i+1) {
+    output[i] = input[2*i];
+    output[i+xlen()/2] = input[2*i+1];
+  }
+
+  X[rd] = output;
+
+
+sail(): |
+
   foreach (i from 0 to xlen/2-1) {
-    X(rd)[i] = X(rs1)[2*i]
-    X(rd)[i+xlen/2] = X(rs1)[2*i+1]
+    X(rd)[i] = X(rs1)[2*i];
+    X(rd)[i+xlen/2] = X(rs1)[2*i+1];
   }

arch/inst/Zbkb/zip.yaml

@@ -30,7 +30,19 @@ operation(): |
     raise (ExceptionCode::IllegalInstruction, mode(), $encoding);
   }
 
+  XReg input = X[rs1];
+  XReg output = 0;
+
+  for(U32 i=0; i<(xlen()/2-1); i = i+1){
+    output[2*i] = input[i];
+    output[2*i+1] = input[i+xlen()/2];
+  }
+
+  X[rd] = output;
+
+sail(): |
+
   foreach (i from 0 to xlen/2-1) {
-    X(rd)[2*i] = X(rs1)[i]
-    X(rd)[2*i+1] = X(rs1)[i+xlen/2]
+    X(rd)[2*i] = X(rs1)[i];
+    X(rd)[2*i+1] = X(rs1)[i+xlen/2];
   }