Many cleanups to get better quality profiles. Also changed ratification_date from null to unknown to be consistent.

james-ball-qualcomm · james-ball-qualcomm · commit db874da7ef48 · 2024-12-03T22:00:31.000-08:00
diff --git a/arch/ext/Smcdeleg.yaml b/arch/ext/Smcdeleg.yaml
@@ -16,7 +16,7 @@ doc_license:
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   repositories:
     - url: https://github.com/riscvarchive/riscv-smcdeleg-ssccfg
   url: https://github.com/riscvarchive/riscv-smcdeleg-ssccfg/releases/download/v1.0.0/riscv-smcdeleg-ssccfg-v1.0.0.pdf
diff --git a/arch/ext/Ssccfg.yaml b/arch/ext/Ssccfg.yaml
@@ -9,5 +9,5 @@ type: privileged
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   url: https://docs.google.com/document/d/1s-GeH5XpHBLzbQZucA8DPA7vvF7Xvf_nrPbrU2YLBcE/edit#heading=h.yyrgtolcaczx
diff --git a/arch/ext/Ssccptr.yaml b/arch/ext/Ssccptr.yaml
@@ -13,7 +13,7 @@ type: privileged
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   url: https://github.com/riscv/riscv-profiles/releases/tag/v1.0
   repositories:
     - url: https://github.com/riscv/riscv-profiles
diff --git a/arch/ext/Sstc.yaml b/arch/ext/Sstc.yaml
@@ -3,11 +3,10 @@
 $schema: "ext_schema.json#"
 kind: extension
 name: Sstc
-long_name: Superivisor mode timer interrupts
-description: Superivisor mode timer interrupts
+long_name: Supervisor-mode timer interrupts
+description: Supervisor-mode timer interrupts
 type: privileged
 versions:
-- version: "0.9.0"
+- version: "1.0.0"
   state: ratified
-  ratification_date: null
-  url: https://drive.google.com/file/d/1m84Re2yK8m_vbW7TspvevCDR82MOBaSX/view?usp=drive_link
+  ratification_date: unknown
diff --git a/arch/ext/Sstvala.yaml b/arch/ext/Sstvala.yaml
@@ -19,7 +19,7 @@ type: privileged
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   url: https://github.com/riscv/riscv-profiles/releases/tag/v1.0
   repositories:
     - url: https://github.com/riscv/riscv-profiles
diff --git a/arch/ext/Sstvecd.yaml b/arch/ext/Sstvecd.yaml
@@ -12,7 +12,7 @@ type: privileged
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   url: https://github.com/riscv/riscv-profiles/releases/tag/v1.0
   repositories:
     - url: https://github.com/riscv/riscv-profiles
diff --git a/arch/ext/Ssu64xl.yaml b/arch/ext/Ssu64xl.yaml
@@ -0,0 +1,15 @@
+# yaml-language-server: $schema=../../schemas/ext_schema.json
+
+$schema: "ext_schema.json#"
+kind: extension
+name: Ssu64xl
+long_name: UXLEN=64 must be supported
+description: |
+  `sstatus.UXL` must be capable of holding the value 2 (i.e., UXLEN=64 must be supported).
+
+  [NOTE]
+  This extension was ratified as part of the RVA20 profile.
+versions:
+- version: "1.0.0"
+  state: ratified
+  ratification_date: unknown
diff --git a/arch/ext/Svbare.yaml b/arch/ext/Svbare.yaml
@@ -13,7 +13,7 @@ description: |
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   requires:
     name: S
   param_constraints:
diff --git a/arch/ext/Svpbmt.yaml b/arch/ext/Svpbmt.yaml
@@ -14,7 +14,7 @@ type: privileged
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   requires:
     name: Sv39
   param_constraints:
diff --git a/arch/ext/U.yaml b/arch/ext/U.yaml
@@ -3,11 +3,13 @@
 $schema: "ext_schema.json#"
 kind: extension
 name: U
-long_name: User-level privilege mode
-description: User-level privilege mode
+long_name: User-mode privilege level
+description: |
+  User-mode privilege level is supported by an implementation if the U extension is present.
+  Note that the RISC-V ISA doens't formally define a U extension and it is only discussed in the Privileged ISA manual.
 type: privileged
 versions:
-- version: "1.12.0"
+- version: "1.0.0"
   state: ratified
   ratification_date: 2019-12
 params:
diff --git a/arch/ext/V.yaml b/arch/ext/V.yaml
@@ -8,7 +8,7 @@ long_name: Variable-length vector
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
 description: |
   TODO
 params:
diff --git a/arch/ext/Za128rs.yaml b/arch/ext/Za128rs.yaml
@@ -16,7 +16,7 @@ description: |
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   param_constraints:
     LRSC_RESERVATION_STRATEGY:
       schema:
diff --git a/arch/ext/Zic64b.yaml b/arch/ext/Zic64b.yaml
@@ -13,7 +13,7 @@ type: privileged
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   url: https://github.com/riscv/riscv-profiles/releases/tag/v1.0
   repositories:
     - url: https://github.com/riscv/riscv-profiles
diff --git a/arch/ext/Ziccamoa.yaml b/arch/ext/Ziccamoa.yaml
@@ -12,4 +12,4 @@ description: |
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
diff --git a/arch/ext/Ziccif.yaml b/arch/ext/Ziccif.yaml
@@ -14,4 +14,4 @@ description: |
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
diff --git a/arch/ext/Zicclsm.yaml b/arch/ext/Zicclsm.yaml
@@ -20,7 +20,7 @@ description: |
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   param_constraints:
     MISALIGNED_LDST:
       schema:
diff --git a/arch/ext/Ziccrse.yaml b/arch/ext/Ziccrse.yaml
@@ -12,4 +12,4 @@ description: |
 versions:
 - version: "1.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
diff --git a/arch/ext/Zicsr.yaml b/arch/ext/Zicsr.yaml
@@ -9,4 +9,4 @@ type: unprivileged
 versions:
 - version: "2.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
diff --git a/arch/ext/Zifencei.yaml b/arch/ext/Zifencei.yaml
@@ -69,4 +69,4 @@ type: unprivileged
 versions:
 - version: "2.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
diff --git a/arch/ext/Zihintpause.yaml b/arch/ext/Zihintpause.yaml
@@ -70,4 +70,4 @@ type: unprivileged
 versions:
 - version: "2.0.0"
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
diff --git a/arch/ext/Zkt.yaml b/arch/ext/Zkt.yaml
@@ -354,7 +354,7 @@ versions:
   - name: Claire Wolf
 - version: 1.0.1
   state: ratified
-  ratification_date: null
+  ratification_date: unknown
   changes:
   - Fix typos to show that `c.srli`, `c.srai`, and `c.slli` are Zkt instructions in RV64.
 company:
diff --git a/arch/profile_release/RVA20.yaml b/arch/profile_release/RVA20.yaml
@@ -55,13 +55,6 @@ RVA20:
           presence: mandatory
         M:
           presence: mandatory
-        U:
-          presence: mandatory
-          version: "~> 2.0"
-          param_constraints:
-            U_MODE_ENDIANESS:
-              schema:
-                const: little
         Zicntr:
           presence: mandatory
         Ziccif:
@@ -138,6 +131,13 @@ RVA20:
         supervisor-mode execution environment in 64-bit applications
         processors.  RVA20S64 is based on privileged architecture version 1.11.
       extensions:
+        U:
+          presence: mandatory
+          version: "~> 1.0"
+          param_constraints:
+            U_MODE_ENDIANESS:
+              schema:
+                const: little
         S:
           presence: mandatory
           version: "~> 1.11"
diff --git a/backends/profile_doc/templates/profile.adoc.erb b/backends/profile_doc/templates/profile.adoc.erb
@@ -441,7 +441,7 @@ Extensions present in a profile are also present in higher-privileged profiles i
 === <%= ext.name %> Extension
 <%= ext.long_name %>
 
-.Presence
+.<%= ext.name %> Extension Presence
 |===
 | Profile | v<%= ext.versions.map { |v| v.version }.join(" | v") %>
 
@@ -453,27 +453,31 @@ Extensions present in a profile are also present in higher-privileged profiles i
 
 <% ext.versions.each do |v| -%>
 <%= v.version %>::
+  State:::
+    <%= v.state %>
+  <% if v.state == "ratified" -%>
   Ratification date:::
     <%= v.ratification_date %>
+  <% end # if %>
   <% unless v.changes.empty? -%>
   Changes:::
 
     <% v.changes.each do |c| -%>
     * <%= c %>  
     <% end -%>
 
-  <%- end -%>
-  <%- unless v.url.nil? -%>
+  <% end -%>
+  <% unless v.url.nil? -%>
   Ratification document:::
     <%= v.url %>
-  <%- end -%>
-  <%- unless v.implications -%>
+  <% end -%>
+  <% unless v.implications -%>
   Implies:::
-    <%- v.implications.each do |i| -%>
+    <% v.implications.each do |i| -%>
     * `<%= i.name %>` version <%= i.version %>
-    <%- end -%>
-  <%- end -%>
-<%- end -%>
+    <% end -%>
+  <% end -%>
+<% end -%>
 
 ==== Synopsis
 
@@ -484,8 +488,8 @@ Extensions present in a profile are also present in higher-privileged profiles i
 :leveloffset: -3
 
 // TODO: GitHub issue 92: Use version specified by each profile and add version info to inst table below.
-<%- insts = arch_def.instructions.select { |i| i.defined_by?(ext.min_version) } -%>
-<%- unless insts.empty? -%>
+<% insts = arch_def.instructions.select { |i| i.defined_by?(ext.min_version) } -%>
+<% unless insts.empty? -%>
 ==== Instructions
 
 The following instructions are added by this extension:
diff --git a/cfgs/generic_rv64/arch_overlay/ext/Xcustom.yaml b/cfgs/generic_rv64/arch_overlay/ext/Xcustom.yaml
@@ -6,7 +6,7 @@ long_name: A new custom extension!
 type: unprivileged
 versions:
 - version: "0.1.0"
-  ratification_date: null
+  ratification_date: unknown
   state: development
 description: |
   A new custom extension!
diff --git a/lib/arch_obj_models/certificate.rb b/lib/arch_obj_models/certificate.rb
@@ -79,7 +79,7 @@ def when_pretty
             "Parameter #{param_name} == #{param_value}"
           end
         else
-          raise "TODO: when type #{key} not implemented"
+          raise "Type #{key} not implemented"
         end
       end.flatten.join(" and ")
     end
@@ -111,7 +111,7 @@ def when_pretty
             "Parameter #{param_name} == #{param_value}"
           end
         else
-          raise "TODO: when type #{key} not implemented"
+          raise "Type #{key} not implemented"
         end
       end.flatten.join(" and ")
     end
diff --git a/lib/arch_obj_models/extension.rb b/lib/arch_obj_models/extension.rb
diff --git a/lib/arch_obj_models/portfolio.rb b/lib/arch_obj_models/portfolio.rb
diff --git a/lib/arch_obj_models/schema.rb b/lib/arch_obj_models/schema.rb
