refactor: remove duplication in setup script #1219
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1219 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThinkOpenly
approved these changes
Oct 30, 2025
dhower-qc
approved these changes
Oct 31, 2025
Collaborator
|
Looks like a recent merge introduced a conflict. Could you rebase, please? |
The executable variable definitions were duplicated for each container type so they could be prefixed with the necessary commands to run the executable from within the container. the `$RUN` variable already had this command set for each container type, so use that universally instead.
jordancarlin
force-pushed
the
setup_run_duplication
branch
from
8ba393b to
db0294a
Compare
Contributor
Author
Done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The executable variable definitions were duplicated for each container type so they could be prefixed with the necessary commands to run the executable from within the container. The
$RUNvariable already had this command set for each container type, so use that universally instead.