-
Notifications
You must be signed in to change notification settings - Fork 78
Add missing CSRs #1236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add missing CSRs #1236
Conversation
|
It appears that That leaves Looks like to get these new CSRs to pass the CI tests, we'll need to add the fields.
[FYI, I removed "ustatus, uie, utvec, uscratch, uepc, ucause, utval, uip, sedeleg, sideleg" from the PR description.] |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1236 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ThinkOpenly
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! CI passed!
Just a few nits, then we'll get this merged.
| @@ -0,0 +1,26 @@ | |||
| # Copyright (c) Qualcomm Technologies, Inc. and/or its subsidiaries. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are encouraged to put your own copyright here, since this is your work! :-) Here, and the other files as well, of course.
(There are plenty of examples in the repo.)
| alias: | ||
| - mie.SSIE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all of the alias attributes. "alias" means that this field actually is another means of accessing the aliased field. Here, though, the field is standalone. It corresponds to the other register's fields for convenience, but is distinct.
| alias: | ||
| - mie.SSIE | ||
| description: | | ||
| *Supervisor Software Interrupt Enable* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove the * characters, here and elsewhere.
| *Supervisor Software Interrupt Enable* | ||
| type: RW | ||
| reset_value: UNDEFINED_LEGAL | ||
| definedBy: S |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the field is definedBy the same extension as the CSR, then it does not need to be explicitly specified, so remove all definedBy: S attributes.
Adds basic information for missing CSRs necessary for #1209. List of CSRs: sie, dscratch0, dscratch1
Based on: