fix: address missing assembly section for instructions with no operands #1237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove conditional check that hides Assembly section when assembly field is empty. Now instructions like fence.i will properly show "Assembly:: fence.i" in the instruction appendix instead of omitting the section entirely. Co-authored-by: Afonso Oliveira <[email protected]> Co-authored-by: Paul A. Clarke <[email protected]> Signed-off-by: Paul A. Clarke <[email protected]>
ThinkOpenly
force-pushed
the
missing-assembly
branch
from
6ca27c9 to
f96403b
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1237 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jordancarlin
approved these changes
Nov 7, 2025
dhower-qc
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove conditional check that hides Assembly section when assembly field is empty. Now instructions like
fence.iwill properly show "Assembly:: fence.i" in the instruction appendix instead of omitting the section entirely.