Skip to content

Conversation

@jordancarlin
Copy link
Contributor

@jordancarlin jordancarlin commented Nov 11, 2025

The GitHub pages deployment workflow was failing due to missing RVI20 CRD artifacts. This updates the names in .github/workflows/pages.yml (download artifacts) to be lowercase so they match with those in .github/workflows/deploy.yml (upload artifacts).

fixes #1241

@jordancarlin
Copy link
Contributor Author

@james-ball-qualcomm

@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 46.05%. Comparing base (04c2909) to head (4abb16c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1242   +/-   ##
=======================================
  Coverage   46.05%   46.05%           
=======================================
  Files          11       11           
  Lines        4942     4942           
  Branches     1345     1345           
=======================================
  Hits         2276     2276           
  Misses       2666     2666           
Flag Coverage Δ
idlc 46.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@james-ball-qualcomm
Copy link
Collaborator

Wow! Thanks Jordan.

@ThinkOpenly
Copy link
Collaborator

Just so I understand, does this change make the file names in .github/workflows/deploy.yml (upload artifacts) agree with those in .github/workflows/pages.yml (download artifacts)? (There are a lot of existing instances of both cases, so it's a bit challenging for me to follow.)

If you don't mind, could you add a bit to the PR message: describe the problem and how your changes fix it?

@jordancarlin
Copy link
Contributor Author

If you don't mind, could you add a bit to the PR message: describe the problem and how your changes fix it?

@ThinkOpenly updated

@dhower-qc dhower-qc added this pull request to the merge queue Nov 11, 2025
@ThinkOpenly
Copy link
Collaborator

[just pulling this from a related email thread, authored by Derek]
The problem was the commit that added these to CI:

feat: Added RVI20 CRDs to deploy and artifacts web site by james-ball-qualcomm · Pull Request #1224 · riscv-software-src/riscv-unified-db

It uploads them using lowercase names and then tries to download them using uppercase.

Merged via the queue into riscv-software-src:main with commit 89d26be Nov 11, 2025
52 checks passed
@jordancarlin jordancarlin deleted the rvi20-crd-deployment branch November 11, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deploy github action fails due to missing RVI20-32-crd

4 participants