-
Notifications
You must be signed in to change notification settings - Fork 78
fix(ci): correct RVI20 CRD artifact names in GitHub Pages deployment workflow #1242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ci): correct RVI20 CRD artifact names in GitHub Pages deployment workflow #1242
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1242 +/- ##
=======================================
Coverage 46.05% 46.05%
=======================================
Files 11 11
Lines 4942 4942
Branches 1345 1345
=======================================
Hits 2276 2276
Misses 2666 2666
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Wow! Thanks Jordan. |
|
Just so I understand, does this change make the file names in If you don't mind, could you add a bit to the PR message: describe the problem and how your changes fix it? |
@ThinkOpenly updated |
|
[just pulling this from a related email thread, authored by Derek] It uploads them using lowercase names and then tries to download them using uppercase. |
The GitHub pages deployment workflow was failing due to missing RVI20 CRD artifacts. This updates the names in
.github/workflows/pages.yml(download artifacts) to be lowercase so they match with those in.github/workflows/deploy.yml(upload artifacts).fixes #1241