Skip to content

Crypto Extensions #188

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Oct 29, 2024
Merged

Crypto Extensions #188

merged 15 commits into from
Oct 29, 2024

Conversation

@AFOliveira
Copy link
Collaborator

@AFOliveira AFOliveira commented Oct 25, 2024

In B extension, although instructions already have the data_independent_timing: true , it also make senses to describe the crypto extensions, since they technically also include those instructions, as described in the ISA Manual :
image

Moreover, I added them in conformity with B extension format [Extension, Subextension, Subextension], e.g.

packw:
...
  definedBy:
    anyOf: [Zbkb, Zk, Zkn, Zks]

@AFOliveira AFOliveira requested a review from dhower-qc as a code owner October 25, 2024 10:13
@AFOliveira
Fix small typos
afefa4c 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira AFOliveira force-pushed the AFOliveira/InstructionsSkeletons branch from c99a9e9 to afefa4c Compare October 25, 2024 10:18
@AFOliveira
Added Zimop instructions
75c5685 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira
Added Zks instructions
6ad1f6f 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira
Added Zvbb instructions
aa7139e 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira
Added Zvbc instructions
ee42b7f 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira
Added Zvfbmin instructions
141c3a2 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira
Added Zvfbfwma instructions
97b28b5 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira
Added Zvkg instructions
3216eb9 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira AFOliveira changed the title Zk extension Crypto Extensions Oct 25, 2024
@AFOliveira
Added Zvkn instructions
ff71990 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira
Added Zvks instructions
7f292fb 
Signed-off-by: Afonso Oliveira <[email protected]>
@AFOliveira AFOliveira force-pushed the AFOliveira/InstructionsSkeletons branch from f40f05f to 7f292fb Compare October 25, 2024 11:28
@AFOliveira AFOliveira mentioned this pull request Oct 27, 2024
Closed
dhower-qc
dhower-qc approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@dhower-qc dhower-qc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dhower-qc dhower-qc merged commit d647b55 into main Oct 29, 2024
1 check passed
@dhower-qc dhower-qc deleted the AFOliveira/InstructionsSkeletons branch October 29, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dhower-qc dhower-qc dhower-qc approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AFOliveira @dhower-qc