-
Notifications
You must be signed in to change notification settings - Fork 78
Schema change #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Schema change #271
Conversation
james-ball-qualcomm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do I only see changes to one certificate_model? Shouldn't this change require all the certificate arch files (models & classes) and profile arch files (releases & classes) to be changed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The examples in arch/README.adoc need to be updated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you rename MockCertificateModel to MockCertificateModel100? I don't want to hold up merging this into main but I am curious why the change (and somewhat concerned).
|
I'm going to restore the original name of MockCertificateModel. Also, I noticed that there is no Profile schema and the Profile Release and Profile Class haven't been updated yet. Is that on your list to change relatively soon? |
|
What happened to these tests in test_yaml_loader.rb? Why were they removed? Were they renamed or moved somewhere else? def test_refs_in_the_same_document end def test_refs_in_the_different_document end |
|
We aren't expanding $ref any more; just $inherits. |
|
Thanks. Can you explain how $ref works now vs. before? Also, do we still need all the code for $ref in yaml_loader.rb? |
fixes #246