Fix definedBy on some instructions #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
@dhower-qc is this also repeated from what you did on #350? If so I guess we can just close it. |
Merged
Collaborator
|
Fixed in #350 |
This was referenced Dec 19, 2024
Closed
Collaborator
Author
|
#362 Explains what happened here, I'll fix this PR. |
Signed-off-by: Afonso Oliveira <[email protected]>
Signed-off-by: Afonso Oliveira <[email protected]>
AFOliveira
force-pushed
the
fixDefined
branch
from
d272f27 to
ae19103
Compare
dhower-qc
requested changes
Jan 8, 2025
Collaborator
Author
|
There is an error with missing Zhinx extension in the UDB:
|
Collaborator
|
Go ahead and add Zhinx, with a new issue to remind us that Zhinx is not implemented (since a simple look for empty operation() won't catch it) |
Collaborator
Author
|
@dhower-qc Done! |
ThinkOpenly
reviewed
Jan 12, 2025
AFOliveira
force-pushed
the
fixDefined
branch
2 times, most recently
from
5ffbb4e to
36e03eb
Compare
AFOliveira
force-pushed
the
fixDefined
branch
from
36e03eb to
c3e00a2
Compare
dhower-qc
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As caught and reported by @ThinkOpenly. Solves #319 . Solves #322 .