Improved support for devcontainer #389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tup to fix smoke test.
Signed-off-by: james-ball-qualcomm <[email protected]>
Collaborator
Author
|
Looks like this small PR can be approved. @dhower-qc |
dhower-qc
reviewed
Jan 9, 2025
Collaborator
dhower-qc
left a comment
dhower-qc
left a comment
There was a problem hiding this comment.
Since the meat of this is already pushed, we probably just want to abandon this PR.
| diag-ditaa-* | ||
| arch/manual/isa/**/riscv-isa-manual | ||
| gen | ||
| gen.* |
Collaborator
Author
There was a problem hiding this comment.
Yes, wanted to talk to you about this one. I'd like to have the ability to keep old copies of the generated files in my workspace for reference. I want them ignored by Git. So, my scheme is to take the gen directory and rename it to gen. so that's why I've added gen.* in .gitignore. If you have another way of solving this, I'm open to it. This is just what I was imagining as a solution.
Collaborator
Author
There was a problem hiding this comment.
Derek suggested changing this to *.bak in the .gitignore. I'll do that in some future PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple corrections to script