Fix mret and mnret instructions #588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ThinkOpenly
requested changes
Apr 2, 2025
Collaborator
ThinkOpenly
left a comment
ThinkOpenly
left a comment
There was a problem hiding this comment.
One area of this project we're trying to improve is the commit messages. I'd appreciate it (and it would certainly help me review an area with which I'm not familiar) if the commit message included:
- description of the issue with the current code
- explanation of what was changed, and how that fixes the issue
…t) and MPRV bit Before his fix IDL code reset mstatus.MPRV bit only in case if S mode is implemented for both mret and mnret. This seems wrong, since spec states that MPRV should be reset by both mret and mnret for case when mode processor is returning is different from Machine mode (2b'11). As well, Smdbltrp spec requires that such case (returning to non-machine mode), the mnret instruction should reset MDT bit. According to the spec mnret instruction should set mnstatus.NMIE=1. Also, mnret should use mnstatus.MNPP bit field for previous mode storage. Signed-off-by: Albert Yosher <[email protected]>
…i and Smdbltrp extensions documentation Signed-off-by: Albert Yosher <[email protected]>
dhower-qc
approved these changes
Apr 3, 2025
Collaborator
Author
|
@ThinkOpenly , Please review updated changes and approve them if you thing that I did the requested changes. |
ThinkOpenly
approved these changes
Apr 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for Smdbltrp (MDT bit) and MPRV bit