-
Notifications
You must be signed in to change notification settings - Fork 79
Fix for #633 - pages.yml duplicating artifact building in deploy.sh #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #633 - pages.yml duplicating artifact building in deploy.sh #635
Conversation
…nd was out-of-date and still using "generic_rv64" which has been renamed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR fixes the duplication of artifact building in the pages workflow by consolidating multiple artifact creation steps into a single call to the deploy.sh script. In doing so, it also removes the outdated reference to "generic_rv64" from the workflow.
Comments suppressed due to low confidence (1)
.github/workflows/pages.yml:27
- Ensure that deploy.sh now encompasses all the previously separate artifact creation steps, including the html documentation generation for generic_rv64, to prevent any unintentional omissions.
- name: Create many artifacts in the _site directory
|
BTW there is a linux package called "act" which allows to deploy locally so we can test this type of changes. Not that I am against trying to fix it this way, but it may just be more productive in your side not needing to wait for Derek's approval to test this type of fixes |
|
Ran the deploy.sh script on my laptop and it passed. I recommend you approve this PR and we merge it in. I've attached the output log from the deploy.sh as proof that it now passes. |
|
Thanks Afonso for the tip about the "act" package. I don't seem to have the "act" command in my path on WSL but maybe I can add it. Before I do that, Derek, is this what you recommend? In the meantime, I'm going to research if there is a way to get GitHub to run the pages.yaml action like it does when a PR is merged. Afonso, do you know about this? |
The deploy action publishes artifacts on the Pages site. It can, and should, only run from main. |


and was out-of-date and still using "generic_rv64" which has been renamed.
Let's see after I create this PR if the deploy pages action now works.