Skip to content

Conversation

@james-ball-qualcomm
Copy link
Collaborator

and was out-of-date and still using "generic_rv64" which has been renamed.

Let's see after I create this PR if the deploy pages action now works.

…nd was out-of-date and still using "generic_rv64" which has been renamed.
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes the duplication of artifact building in the pages workflow by consolidating multiple artifact creation steps into a single call to the deploy.sh script. In doing so, it also removes the outdated reference to "generic_rv64" from the workflow.

Comments suppressed due to low confidence (1)

.github/workflows/pages.yml:27

  • Ensure that deploy.sh now encompasses all the previously separate artifact creation steps, including the html documentation generation for generic_rv64, to prevent any unintentional omissions.
- name: Create many artifacts in the _site directory

@AFOliveira
Copy link
Collaborator

BTW there is a linux package called "act" which allows to deploy locally so we can test this type of changes. Not that I am against trying to fix it this way, but it may just be more productive in your side not needing to wait for Derek's approval to test this type of fixes

@james-ball-qualcomm
Copy link
Collaborator Author

Ran the deploy.sh script on my laptop and it passed. I recommend you approve this PR and we merge it in.

I've attached the output log from the deploy.sh as proof that it now passes.
deploy.log

@james-ball-qualcomm
Copy link
Collaborator Author

Thanks Afonso for the tip about the "act" package. I don't seem to have the "act" command in my path on WSL but maybe I can add it. Before I do that, Derek, is this what you recommend? In the meantime, I'm going to research if there is a way to get GitHub to run the pages.yaml action like it does when a PR is merged. Afonso, do you know about this?

@james-ball-qualcomm
Copy link
Collaborator Author

Hold on. I see I can re-run the pages.yaml workflow on my branch with the fix. I'll give that a shot.

image

@james-ball-qualcomm
Copy link
Collaborator Author

james-ball-qualcomm commented Apr 18, 2025

Well, that didn't look good. Seems like I need some kind of permission on my branch that I don't have. Should we try to add permission to this branch? If so, can I do this or do I need Derek?

image

@dhower-qc
Copy link
Collaborator

Well, that didn't look good. Seems like I need some kind of permission on my branch that I don't have. Should we try to add permission to this branch? If so, can I do this or do I need Derek?

The deploy action publishes artifacts on the Pages site. It can, and should, only run from main.

@james-ball-qualcomm james-ball-qualcomm added this pull request to the merge queue Apr 18, 2025
Merged via the queue into main with commit de77b7b Apr 18, 2025
15 of 16 checks passed
@james-ball-qualcomm james-ball-qualcomm deleted the 633-deploy-pages-fails-build-html-gen64 branch April 18, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deploy pages workflow fails after merge of CSC fork into main

4 participants