Skip to content

Commit a73e1bd

Browse files
Merge pull request #213 from riscv/copilot/sub-pr-212
Validate def_filename and def_dir_name in create_param_appendix.py
2 parents 581cb90 + 659db7b commit a73e1bd

File tree

1 file changed

+7
-0
lines changed

1 file changed

+7
-0
lines changed

tools/create_param_appendix.py

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -371,7 +371,14 @@ def write_output_files(
371371
seen_names.add(file_stem)
372372

373373
def_filename = param.get("def_filename", "")
374+
if not isinstance(def_filename, str) or not def_filename:
375+
fatal(f"Expected non-empty def_filename for parameter {name!r}")
374376
def_dir_name = Path(def_filename).stem
377+
if not def_dir_name:
378+
fatal(
379+
f"def_filename {def_filename!r} for parameter {name!r} "
380+
"has no usable stem for a chapter subdirectory name"
381+
)
375382
param_dir = output_dir / def_dir_name
376383
param_dir.mkdir(parents=True, exist_ok=True)
377384

0 commit comments

Comments
 (0)