Skip to content

Commit dd688ff

Browse files
committed
improve accessibility
Signed-off-by: rishichawda <[email protected]>
1 parent edd5da3 commit dd688ff

File tree

4 files changed

+21
-9
lines changed

4 files changed

+21
-9
lines changed

src/components/footer.astro

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ const currentYear = new Date().getFullYear();
1010
target="_blank"
1111
rel="noopener noreferrer"
1212
class="text-gray-500 hover:text-gray-700 transition-colors"
13+
aria-label="Visit Rishi's GitHub profile"
1314
>
1415
<span class="sr-only">GitHub</span>
1516
<svg viewBox="0 0 24 24" class="w-5 h-5 sm:w-6 sm:h-6 fill-current"
@@ -23,6 +24,7 @@ const currentYear = new Date().getFullYear();
2324
target="_blank"
2425
rel="noopener noreferrer"
2526
class="text-gray-500 hover:text-gray-700 transition-colors"
27+
aria-label="Connect with Rishi on LinkedIn"
2628
>
2729
<span class="sr-only">LinkedIn</span>
2830
<svg viewBox="0 0 24 24" class="w-5 h-5 sm:w-6 sm:h-6 fill-current"
@@ -36,6 +38,7 @@ const currentYear = new Date().getFullYear();
3638
target="_blank"
3739
rel="noopener noreferrer"
3840
class="text-gray-500 hover:text-gray-700 transition-colors"
41+
aria-label="Follow Rishi on Instagram"
3942
>
4043
<span class="sr-only">Instagram</span>
4144
<svg

src/components/landing/articles_preview.astro

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -208,9 +208,8 @@ const articles = allArticles
208208
if (dotsContainer) {
209209
dotsContainer.innerHTML = "";
210210
for (let i = 0; i < totalSlides; i++) {
211-
const dot = document.createElement("button");
211+
const dot = document.createElement("span");
212212
dot.className = `w-2 h-2 rounded-full ${i === currentIndex ? "bg-[#B7BEE7]" : "bg-[#B7BEE7]/40"}`;
213-
dot.setAttribute("aria-label", `Go to slide ${i + 1}`);
214213
dot.setAttribute("data-index", i.toString());
215214
dotsContainer.appendChild(dot);
216215
}
Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,22 @@
11
<section class="bg-brand-900/[0.05] py-16 md:py-20 px-4">
22
<div class="max-w-4xl mx-auto text-center">
3-
<h2 class="text-3xl md:text-4xl font-['Red_Hat_Display_Variable'] font-medium text-brand-900 mb-4">
3+
<h2
4+
class="text-3xl md:text-4xl font-['Red_Hat_Display_Variable'] font-medium text-brand-900 mb-4"
5+
>
46
Let's Work Together
57
</h2>
6-
<p class="text-lg md:text-xl font-light text-brand-700 mb-8 font-['Montserrat_Variable']">
7-
Have a project in mind or want to discuss potential opportunities? I'd love to hear from you.
8+
<p
9+
class="text-lg md:text-xl font-light text-brand-700 mb-8 font-['Montserrat_Variable']"
10+
>
11+
Have a project in mind or want to discuss potential opportunities? I'd
12+
love to hear from you.
813
</p>
914
<a
15+
transition:name="cta-cta-button"
1016
href="/contact/"
1117
class="bg-brand-700 text-white px-6 py-3 rounded font-['Red_Hat_Display_Variable'] text-sm font-medium uppercase tracking-wide hover:bg-brand-900 transition-colors text-center"
1218
>
1319
Get in touch
1420
</a>
1521
</div>
16-
</section>
22+
</section>

src/components/landing/hero.astro

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ import logo from "../../../content/assets/logo/Group 489.svg";
1515
>
1616
<!-- Split Background -->
1717
<div class="absolute inset-0 flex">
18-
<div class="w-0 lg:w-1/2 bg-[#98a5db]/[0.88]"></div>
19-
<div class="w-full lg:w-1/2 bg-[#8592c8]"></div>
18+
<div class="w-0 lg:w-1/2 bg-brand-500/[0.88]"></div>
19+
<div class="w-full lg:w-1/2 bg-brand-500"></div>
2020
</div>
2121

2222
<!-- Navigation -->
@@ -106,6 +106,7 @@ import logo from "../../../content/assets/logo/Group 489.svg";
106106
target="_blank"
107107
rel="noopener noreferrer"
108108
class="hover:opacity-80 transition-opacity hover:cursor-pointer"
109+
aria-label="Visit Rishi's GitHub profile"
109110
>
110111
<svg
111112
width="32"
@@ -124,6 +125,7 @@ import logo from "../../../content/assets/logo/Group 489.svg";
124125
target="_blank"
125126
rel="noopener noreferrer"
126127
class="hover:opacity-80 transition-opacity hover:cursor-pointer"
128+
aria-label="Connect with Rishi on LinkedIn"
127129
>
128130
<svg
129131
width="26"
@@ -142,6 +144,7 @@ import logo from "../../../content/assets/logo/Group 489.svg";
142144
target="_blank"
143145
rel="noopener noreferrer"
144146
class="hover:opacity-80 transition-opacity hover:cursor-pointer"
147+
aria-label="Follow Rishi on Instagram"
145148
>
146149
<svg
147150
width="26"
@@ -163,8 +166,9 @@ import logo from "../../../content/assets/logo/Group 489.svg";
163166
<!-- Get in Touch Button -->
164167
<div class="relative z-20 mt-8 w-fit mx-auto mb-4">
165168
<a
169+
transition:name="hero-cta-button"
166170
href="/contact/"
167-
class="bg-brand-500 text-white px-6 py-3 rounded font-['Red_Hat_Display_Variable'] text-sm font-medium uppercase tracking-wide hover:bg-brand-600 transition-colors block text-center"
171+
class="bg-brand-500 text-white px-6 py-3 rounded font-['Red_Hat_Display_Variable'] text-sm font-medium uppercase tracking-wide hover:bg-brand-500 transition-colors block text-center"
168172
>
169173
Get in Touch
170174
</a>

0 commit comments

Comments
 (0)