Fix: Action logs now readable without active executor (Shizuku/Root)

Author: risunCode

app/src/main/java/com/appcontrolx/rollback/RollbackManager.kt

@@ -10,22 +10,26 @@ import java.util.UUID
 
 class RollbackManager(
     private val context: Context,
-    private val executor: CommandExecutor
+    private val executor: CommandExecutor? = null
 ) {
     private val gson = Gson()
     private val snapshotDir = File(context.filesDir, "snapshots").apply { mkdirs() }
     private val snapshotFile = File(snapshotDir, "rollback_snapshot.json")
     private val historyFile = File(snapshotDir, "action_history.json")
 
+    // Secondary constructor for read-only access (no executor needed)
+    constructor(context: Context) : this(context, null)
+    
     companion object {
         private const val TAG = "RollbackManager"
     }
 
-    fun saveSnapshot(packages: List<String>): StateSnapshot {
+    fun saveSnapshot(packages: List<String>): StateSnapshot? {
+        val exec = executor ?: return null
         val states = packages.map { pkg ->
-            val bgStatus = executor.execute("appops get $pkg RUN_IN_BACKGROUND")
-            val wlStatus = executor.execute("appops get $pkg WAKE_LOCK")
-            val enabledStatus = executor.execute("pm list packages -e | grep $pkg")
+            val bgStatus = exec.execute("appops get $pkg RUN_IN_BACKGROUND")
+            val wlStatus = exec.execute("appops get $pkg WAKE_LOCK")
+            val enabledStatus = exec.execute("pm list packages -e | grep $pkg")
 
             AppState(
                 packageName = pkg,
@@ -56,6 +60,7 @@ class RollbackManager(
     }
 
     fun rollback(): Result<Unit> {
+        val exec = executor ?: return Result.failure(Exception("No executor available"))
         val snapshot = getLastSnapshot() 
             ?: return Result.failure(Exception("No snapshot found"))
 
@@ -69,7 +74,7 @@ class RollbackManager(
             }
         }
 
-        return executor.executeBatch(commands)
+        return exec.executeBatch(commands)
     }
 
     fun logAction(action: ActionLog) {

app/src/main/java/com/appcontrolx/ui/ActionLogBottomSheet.kt

@@ -54,6 +54,10 @@ class ActionLogBottomSheet : BottomSheetDialogFragment() {
     }
 
     private fun setupExecutor() {
+        // RollbackManager for reading logs - no executor needed
+        rollbackManager = RollbackManager(requireContext())
+        
+        // Executor only needed for rollback actions
         val mode = PermissionBridge(requireContext()).detectMode()
         val executor: com.appcontrolx.executor.CommandExecutor? = when (mode) {
             is ExecutionMode.Root -> RootExecutor()
@@ -63,6 +67,7 @@ class ActionLogBottomSheet : BottomSheetDialogFragment() {
 
         executor?.let {
             policyManager = BatteryPolicyManager(it)
+            // Create new RollbackManager with executor for rollback capability
             rollbackManager = RollbackManager(requireContext(), it)
         }
     }
@@ -86,14 +91,7 @@ class ActionLogBottomSheet : BottomSheetDialogFragment() {
 
     private fun loadLogs() {
         val b = binding ?: return
-        val rm = rollbackManager
-        
-        if (rm == null) {
-            b.emptyState.visibility = View.VISIBLE
-            b.recyclerView.visibility = View.GONE
-            b.tvEmptyMessage.text = getString(R.string.log_no_mode)
-            return
-        }
+        val rm = rollbackManager ?: RollbackManager(requireContext()) // Fallback for read-only
 
         lifecycleScope.launch {
             val logs = withContext(Dispatchers.IO) {
@@ -125,8 +123,13 @@ class ActionLogBottomSheet : BottomSheetDialogFragment() {
 
     private fun performRollback(log: ActionLog) {
         val b = binding ?: return
-        val pm = policyManager ?: return
-        val rm = rollbackManager ?: return
+        val pm = policyManager
+        val rm = rollbackManager
+        
+        if (pm == null || rm == null) {
+            Toast.makeText(context, R.string.log_no_mode, Toast.LENGTH_SHORT).show()
+            return
+        }
 
         lifecycleScope.launch {
             b.progressBar.visibility = View.VISIBLE