Skip to content

Commit 7fabb64

Browse files
committed
Fix: Replace Timber with Log, fix ActivityListAdapter and AppListAdapter errors
1 parent ca127ff commit 7fabb64

File tree

4 files changed

+26
-23
lines changed

4 files changed

+26
-23
lines changed

app/src/main/java/com/appcontrolx/presentation/viewmodel/AppListViewModel.kt

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import kotlinx.coroutines.flow.MutableStateFlow
99
import kotlinx.coroutines.flow.StateFlow
1010
import kotlinx.coroutines.flow.asStateFlow
1111
import kotlinx.coroutines.launch
12-
import timber.log.Timber
12+
import android.util.Log
1313
import javax.inject.Inject
1414

1515
sealed class AppListUiState {
@@ -36,11 +36,11 @@ class AppListViewModel @Inject constructor(
3636
result.fold(
3737
onSuccess = { apps ->
3838
_uiState.value = AppListUiState.Success(apps)
39-
Timber.d("Loaded ${apps.size} user apps")
39+
Log.d(TAG, "Loaded ${apps.size} user apps")
4040
},
4141
onFailure = { error ->
4242
_uiState.value = AppListUiState.Error(error.message ?: "Unknown error")
43-
Timber.e(error, "Failed to load user apps")
43+
Log.e(TAG, "Failed to load user apps", error)
4444
}
4545
)
4646
}
@@ -54,11 +54,11 @@ class AppListViewModel @Inject constructor(
5454
result.fold(
5555
onSuccess = { apps ->
5656
_uiState.value = AppListUiState.Success(apps)
57-
Timber.d("Loaded ${apps.size} system apps")
57+
Log.d(TAG, "Loaded ${apps.size} system apps")
5858
},
5959
onFailure = { error ->
6060
_uiState.value = AppListUiState.Error(error.message ?: "Unknown error")
61-
Timber.e(error, "Failed to load system apps")
61+
Log.e(TAG, "Failed to load system apps", error)
6262
}
6363
)
6464
}
@@ -88,9 +88,9 @@ class AppListViewModel @Inject constructor(
8888
val result = repository.freezeApp(packageName)
8989
onComplete(result)
9090
if (result.isSuccess) {
91-
Timber.d("App frozen: $packageName")
91+
Log.d(TAG, "App frozen: $packageName")
9292
} else {
93-
Timber.e("Failed to freeze app: $packageName")
93+
Log.e(TAG, "Failed to freeze app: $packageName")
9494
}
9595
}
9696
}
@@ -100,10 +100,14 @@ class AppListViewModel @Inject constructor(
100100
val result = repository.unfreezeApp(packageName)
101101
onComplete(result)
102102
if (result.isSuccess) {
103-
Timber.d("App unfrozen: $packageName")
103+
Log.d(TAG, "App unfrozen: $packageName")
104104
} else {
105-
Timber.e("Failed to unfreeze app: $packageName")
105+
Log.e(TAG, "Failed to unfreeze app: $packageName")
106106
}
107107
}
108108
}
109+
110+
companion object {
111+
private const val TAG = "AppListViewModel"
112+
}
109113
}

app/src/main/java/com/appcontrolx/ui/AboutFragment.kt

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,11 @@ import androidx.lifecycle.lifecycleScope
1313
import com.appcontrolx.R
1414
import com.appcontrolx.databinding.FragmentAboutBinding
1515
import com.appcontrolx.service.PermissionBridge
16+
import android.util.Log
1617
import dagger.hilt.android.AndroidEntryPoint
1718
import kotlinx.coroutines.Dispatchers
1819
import kotlinx.coroutines.launch
1920
import kotlinx.coroutines.withContext
20-
import timber.log.Timber
2121

2222
@AndroidEntryPoint
2323
class AboutFragment : Fragment() {
@@ -48,7 +48,7 @@ class AboutFragment : Fragment() {
4848
b.tvVersion.text = getString(R.string.about_version_format,
4949
packageInfo.versionName, packageInfo.longVersionCode)
5050
} catch (e: Exception) {
51-
Timber.e(e, "Failed to get package info")
51+
Log.e(TAG, "Failed to get package info", e)
5252
}
5353

5454
// Current mode
@@ -118,10 +118,14 @@ class AboutFragment : Fragment() {
118118
try {
119119
startActivity(Intent(Intent.ACTION_VIEW, Uri.parse(url)))
120120
} catch (e: Exception) {
121-
Timber.e(e, "Failed to open URL: $url")
121+
Log.e(TAG, "Failed to open URL: $url", e)
122122
}
123123
}
124124

125+
companion object {
126+
private const val TAG = "AboutFragment"
127+
}
128+
125129
private fun shareApp() {
126130
val intent = Intent(Intent.ACTION_SEND).apply {
127131
type = "text/plain"

app/src/main/java/com/appcontrolx/ui/adapter/ActivityListAdapter.kt

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,16 +30,11 @@ class ActivityListAdapter(
3030
) : RecyclerView.ViewHolder(binding.root) {
3131

3232
fun bind(item: ActivityItem) {
33-
// App icon
34-
if (item.appIcon != null) {
35-
binding.ivAppIcon.setImageDrawable(item.appIcon)
36-
binding.ivAppIcon.visibility = View.VISIBLE
37-
} else {
38-
binding.ivAppIcon.visibility = View.GONE
39-
}
33+
// Hide app icon for simple activity list (icon is in parent group)
34+
binding.ivAppIcon.visibility = View.GONE
4035

41-
binding.tvAppName.text = item.appName
42-
binding.tvActivityName.text = item.activityName.substringAfterLast(".")
36+
binding.tvAppName.text = item.shortName
37+
binding.tvActivityName.text = item.shortName
4338
binding.tvFullName.text = item.activityName
4439

4540
// Show exported badge

app/src/main/java/com/appcontrolx/ui/adapter/AppListAdapter.kt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ class AppListAdapter(
115115
cardApp.setOnClickListener {
116116
if (isSelectionMode) {
117117
toggleSelection(app.packageName)
118-
notifyItemChanged(bindingAdapterPosition)
118+
notifyItemChanged(adapterPosition)
119119
} else {
120120
onInfoClick(app)
121121
}
@@ -128,7 +128,7 @@ class AppListAdapter(
128128
startSelection(app.packageName)
129129
} else {
130130
toggleSelection(app.packageName)
131-
notifyItemChanged(bindingAdapterPosition)
131+
notifyItemChanged(adapterPosition)
132132
}
133133
true
134134
}

0 commit comments

Comments
 (0)