Fix Non-uniform border colors on TextInput (facebook#50880)

NickGerleman · facebook-github-bot · commit 42251ec0edda · 2025-04-23T15:26:04.000-07:00
Summary: Pull Request resolved: facebook#50880 Kotlin conversion exposes unused variable warning. Looks like I broke this a year ago. Changelog: [Android][Fixed] - Fix Non-uniform border colors on TextInput Reviewed By: mdvacca Differential Revision: D73453825 fbshipit-source-id: 8e3fcac8ea55feb518a8d11a6fbdba7ea548ea2b
diff --git a/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.kt b/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/views/text/ReactTextAnchorViewManager.kt
@@ -167,7 +167,7 @@ internal abstract class ReactTextAnchorViewManager<C : ReactBaseTextShadowNode?>
               "borderBottomColor"],
       customType = "Color")
   public fun setBorderColor(view: ReactTextView, index: Int, color: Int?) {
-    BackgroundStyleApplicator.setBorderColor(view, LogicalEdge.ALL, color)
+    BackgroundStyleApplicator.setBorderColor(view, LogicalEdge.values()[index], color)
   }
 
   @ReactProp(name = ViewProps.INCLUDE_FONT_PADDING, defaultBoolean = true)

Original file line number	Diff line number	Diff line change
`@@ -167,7 +167,7 @@ internal abstract class ReactTextAnchorViewManager<C : ReactBaseTextShadowNode?>`
`167`	`167`	`"borderBottomColor"],`
`168`	`168`	`customType = "Color")`
`169`	`169`	`public fun setBorderColor(view: ReactTextView, index: Int, color: Int?) {`
`170`		`- BackgroundStyleApplicator.setBorderColor(view, LogicalEdge.ALL, color)`
	`170`	`+ BackgroundStyleApplicator.setBorderColor(view, LogicalEdge.values()[index], color)`
`171`	`171`	`}`
`172`	`172`
`173`	`173`	`@ReactProp(name = ViewProps.INCLUDE_FONT_PADDING, defaultBoolean = true)`