Fixing Nits :)

Author: Ritesh Shukla

packages/react-native/Libraries/Blob/URLSearchParams.js

@@ -18,8 +18,8 @@ export class URLSearchParams {
       return;
     }
 
-    // URLSearchParams("key1=value1&key2=value2");
     if (typeof params === 'string') {
+      // URLSearchParams("key1=value1&key2=value2");
       params
         .replace(/^\?/, '')
         .split('&')
@@ -32,14 +32,11 @@ export class URLSearchParams {
             .map(part => decodeURIComponent(part.replace(/\+/g, ' ')));
           this.append(key, value);
         });
-    }
-
-    //URLSearchParams([["key1", "value1"], ["key2", "value2"]]);
-    else if (Array.isArray(params)) {
+    } else if (Array.isArray(params)) {
+      //URLSearchParams([["key1", "value1"], ["key2", "value2"]]);
       params.forEach(([key, value]) => this.append(key, value));
-    }
-    //URLSearchParams({ key1: "value1", key2: "value2" });
-    else if (typeof params === 'object') {
+    } else if (typeof params === 'object') {
+      //URLSearchParams({ key1: "value1", key2: "value2" });
       Object.entries(params).forEach(([key, value]) => this.append(key, value));
     }
   }

packages/react-native/Libraries/Blob/__tests__/URL-test.js

@@ -61,12 +61,17 @@ describe('URL', function () {
     expect(searchParams.get('key')).toBe('value');
 
     const paramsFromString = new URLSearchParams(
-      '?param1=value1+value2&param2=value%20with%20space',
+      [
+        '?param1=value1',
+        '&param2=value2%20with%20spaces',
+        '&param3=value3+with+spaces+legacy',
+      ].join(''),
     );
-    expect(paramsFromString.get('param1')).toBe('value1 value2');
-    expect(paramsFromString.get('param2')).toBe('value with space');
+    expect(paramsFromString.get('param1')).toBe('value1');
+    expect(paramsFromString.get('param2')).toBe('value2 with spaces');
+    expect(paramsFromString.get('param3')).toBe('value3 with spaces legacy');
     expect(paramsFromString.toString()).toBe(
-      'param1=value1+value2&param2=value+with+space',
+      'param1=value1&param2=value2+with+spaces&param3=value3+with+spaces+legacy',
     );
 
     const paramsFromObject = new URLSearchParams({