Skip to content

Commit 847f890

Browse files
mdvaccafacebook-github-bot
authored andcommitted
Update non-codegen ViewManagerInterfaces to extend ViewManagerWithGeneratedInterface (facebook#49274)
Summary: Pull Request resolved: facebook#49274 In this diff I'm updating all the non-codegen ViewManagerInterfaces to extend ViewManagerWithGeneratedInterface to make it consistent with codenerated ViewManagerInterfaces changelog: [internal] internal Reviewed By: javache Differential Revision: D69206247 fbshipit-source-id: 6a577d9ee7410be990a03e78847333b61b429e88
1 parent 6e0e72d commit 847f890

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

packages/react-native-popup-menu-android/android/src/main/java/com/facebook/react/viewmanagers/AndroidPopupMenuManagerInterface.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@
1212
import android.view.View;
1313
import androidx.annotation.Nullable;
1414
import com.facebook.react.bridge.ReadableArray;
15+
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
1516

16-
public interface AndroidPopupMenuManagerInterface<T extends View> {
17+
public interface AndroidPopupMenuManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
1718
void setMenuItems(T view, @Nullable ReadableArray value);
1819
void show(T view);
1920
}

packages/react-native-test-library/android/src/main/java/com/facebook/react/viewmanagers/SampleNativeComponentManagerInterface.java

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,9 @@
1212
import android.view.View;
1313
import androidx.annotation.Nullable;
1414
import com.facebook.react.bridge.ReadableArray;
15+
import com.facebook.react.uimanager.ViewManagerWithGeneratedInterface;
1516

16-
public interface SampleNativeComponentManagerInterface<T extends View> {
17+
public interface SampleNativeComponentManagerInterface<T extends View> extends ViewManagerWithGeneratedInterface {
1718
void setOpacity(T view, float value);
1819
void setValues(T view, @Nullable ReadableArray value);
1920
void changeBackgroundColor(T view, String color);

0 commit comments

Comments
 (0)