Skip to content

Commit a2d8cbf

Browse files
authored
[LOCAL] Do not install CMake on Windows machine (facebook#48139)
This replicates a fix in 00d5cae. 0.75 hadn't factored this out into a separate action.
1 parent f5f700f commit a2d8cbf

File tree

4 files changed

+0
-12
lines changed

4 files changed

+0
-12
lines changed

.circleci/configurations/jobs.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1028,9 +1028,6 @@ jobs:
10281028
name: Build HermesC for Windows
10291029
command: |
10301030
if (-not(Test-Path -Path $Env:HERMES_WS_DIR\win64-bin\hermesc.exe)) {
1031-
choco install --no-progress cmake -y
1032-
if (-not $?) { throw "Failed to install CMake" }
1033-
10341031
cd $Env:HERMES_WS_DIR\icu
10351032
# If Invoke-WebRequest shows a progress bar, it will fail with
10361033
# Win32 internal error "Access is denied" 0x5 occurred [...]

.github/workflows/nightly.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -469,9 +469,6 @@ jobs:
469469
- name: Build HermesC for Windows
470470
run: |
471471
if (-not(Test-Path -Path $Env:HERMES_WS_DIR\win64-bin\hermesc.exe)) {
472-
choco install --no-progress cmake --version 3.14.7
473-
if (-not $?) { throw "Failed to install CMake" }
474-
475472
cd $Env:HERMES_WS_DIR\icu
476473
# If Invoke-WebRequest shows a progress bar, it will fail with
477474
# Win32 internal error "Access is denied" 0x5 occurred [...]

.github/workflows/publish-release.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -466,9 +466,6 @@ jobs:
466466
- name: Build HermesC for Windows
467467
run: |
468468
if (-not(Test-Path -Path $Env:HERMES_WS_DIR\win64-bin\hermesc.exe)) {
469-
choco install --no-progress cmake --version 3.14.7
470-
if (-not $?) { throw "Failed to install CMake" }
471-
472469
cd $Env:HERMES_WS_DIR\icu
473470
# If Invoke-WebRequest shows a progress bar, it will fail with
474471
# Win32 internal error "Access is denied" 0x5 occurred [...]

.github/workflows/test-all.yml

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -543,9 +543,6 @@ jobs:
543543
- name: Build HermesC for Windows
544544
run: |
545545
if (-not(Test-Path -Path $Env:HERMES_WS_DIR\win64-bin\hermesc.exe)) {
546-
choco install --no-progress cmake --version 3.14.7
547-
if (-not $?) { throw "Failed to install CMake" }
548-
549546
cd $Env:HERMES_WS_DIR\icu
550547
# If Invoke-WebRequest shows a progress bar, it will fail with
551548
# Win32 internal error "Access is denied" 0x5 occurred [...]

0 commit comments

Comments
 (0)