Manifest update from V2 to V3 in manifest.json (#129)

* chrome.runtime null check

* manifest update from V2 to V3

* undefined check

* remove unused function parameter in getConfigFromLocalStorage()

* undefined window check for localStroage getter/setter.

* change localStorage to chrome.storage.local

* Change of host_permissions

* async handling

* keep callback active in chrome.runtime.onMessage

* revert host_permissions

* Remove chrome and chrome.runtime null check.

Author: karanugale

background.js

@@ -16,12 +16,15 @@
     }
 
     function storeConfigToLocalStorage(data) {
-        localStorage.setItem(SETUP_STRING, JSON.stringify(data || {}));
+        chrome.storage.local.set({ [SETUP_STRING]: data || {} });
     }
-
-    function getConfigFromLocalStorage(data) {
-        const val = localStorage.getItem(SETUP_STRING);
-        return JSON.parse(val) || {};
+    
+    function getConfigFromLocalStorage() {
+        return new Promise((resolve) => {
+            chrome.storage.local.get([SETUP_STRING], (result) => {
+                resolve(result[SETUP_STRING] || {});
+            });
+        });
     }
 
     chrome.runtime.onMessage.addListener((msg, sender, sendResponse) => {
@@ -32,10 +35,12 @@
             sendMsgToAllContainPage('live-server-config-updated', msg.data);
         }
         else if (msg.req === 'get-live-server-config') {
-            const data = getConfigFromLocalStorage();
-            sendResponse(data);
+            getConfigFromLocalStorage().then(
+                function (value) { sendResponse(value) },
+                function (error) { console.error(`Error: ${error}`) }
+            );
         }
-
+        return true; //Keep the callback(sendResponse) active
     });
 
 })();

manifest.json

@@ -1,5 +1,5 @@
 {
-    "manifest_version": 2,
+    "manifest_version": 3,
     "name": "Live Server Web Extension",
     "version": "1.4.0",
     "description": " Makes your existing server live. This is a browser extension that helps you to live reload feature for dynamic pages",
@@ -22,16 +22,18 @@
         }
     ],
     "background": {
-        "scripts": [
-            "background.js"
-        ]
+        "service_worker": "background.js",
+        "type": "module"
     },
-    "browser_action": {
+    "action": {
         "default_popup": "./popup/popup.html",
         "default_icon": "./img/icon.png",
         "default_title": "Live Server"
     },
     "permissions": [
+        "storage"
+    ],
+    "host_permissions": [
         "http://*/*",
         "https://*/*"
     ]

popup/popup.js

@@ -1,5 +1,5 @@
 ; (function () {
-    
+
     'use strict';
 
     const liveReloadCheck = document.getElementById('liveReloadCheck');
@@ -18,10 +18,12 @@
             liveServerUrl: liveServerAddress.value || ''
         }
 
-        chrome.runtime.sendMessage({
-            req: 'set-live-server-config',
-            data: formData
-        });
+        if (chrome && chrome.runtime) {
+            chrome.runtime.sendMessage({
+                req: 'set-live-server-config',
+                data: formData
+            });
+        }
     }
 
     liveReloadCheck.onclick = () => {
@@ -39,12 +41,13 @@
         chrome.runtime.sendMessage({
             req: 'get-live-server-config'
         }, (data) => {
-            console.log('popupwidnow')
-            liveReloadCheck.checked = data.isEnable || false;
-            noProxyCheckBox.checked = !data.proxySetup;
-            actualServerAddress.value = data.actualUrl || '';
-            liveServerAddress.value = data.liveServerUrl || '';
-            serverSetupDiv.className =  noProxyCheckBox.checked ? 'show' : 'hide';
+            if (data) {
+                liveReloadCheck.checked = data.isEnable || false;
+                noProxyCheckBox.checked = !data.proxySetup;
+                actualServerAddress.value = data.actualUrl || '';
+                liveServerAddress.value = data.liveServerUrl || '';
+                serverSetupDiv.className = noProxyCheckBox.checked ? 'show' : 'hide';
+            }
         });
     });