Skip to content

Commit 63ba111

Browse files
author
klingerj
committed
Split up subpass from resource allocation for draw. Move draw limit check to before resource allocation occurs (and can fail)
There is an issue where resource allocation for draws (which currently refers to only coverage buffer and feather atlas allocations) from within allocateResourcesAndSubpasses() can succeed, but be followed by a failed check for hitting an internal draw limit. This causes the draw that was attempted to be submitted/pushed to reattempt to push a second time, and then make a second allocation. Besides being slightly wasteful it seems to cause asserts to hit when atlas draws are being processed, only when running the fuzz tool. Maybe subpasses can be determined upon creation rather than relatively "late", at resource allocation time? Diffs= e97d77938d Renderer - move draw limit check to run before draw resource allocation occurs (#9200)
1 parent d885e48 commit 63ba111

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

.rive_head

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
48b57c6062ce2817a8f5ac5adfeedf9b117987c7
1+
e97d77938d3e17dc9fc4de03db7f7cb5d16bfb8b

0 commit comments

Comments
 (0)