Skip to content

Commit 4e0c53a

Browse files
committed
test: clarify skip reasons for Android experimental test guards
1 parent 8ff8a24 commit 4e0c53a

File tree

3 files changed

+7
-3
lines changed

3 files changed

+7
-3
lines changed

example/__tests__/autoplay.harness.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -274,7 +274,8 @@ describe('autoPlay prop (issue #138)', () => {
274274

275275
describe('Auto dataBind with no default ViewModel (issue #189)', () => {
276276
it('auto-binds default ViewModel when one exists', async () => {
277-
// getViewModelInstance() not yet available on Android experimental
277+
// getViewModelInstance() returns null on Android experimental — auto-bind
278+
// doesn't expose the VMI handle to JS yet
278279
const isAndroidExperimental =
279280
Platform.OS === 'android' &&
280281
RiveFileFactory.getBackend() === 'experimental';

example/__tests__/rive.harness.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ describe('ViewModel', () => {
3636
expect(vm1).toBeDefined();
3737
expect(vm2).toBeDefined();
3838

39+
// Experimental backends don't validate nested VM paths — the SDK returns
40+
// a handle even for nonexistent paths instead of null.
3941
const isExperimental = RiveFileFactory.getBackend() === 'experimental';
4042
if (!isExperimental) {
4143
expect(await instance?.viewModelAsync('nonexistent')).toBeUndefined();
@@ -47,7 +49,7 @@ describe('ViewModel', () => {
4749
});
4850

4951
it('replaceViewModel() replaces and shares state', async () => {
50-
// replaceViewModel state propagation not yet working on Android experimental
52+
// replaceViewModel is a no-op on Android experimental (not yet implemented)
5153
const isAndroidExperimental =
5254
Platform.OS === 'android' &&
5355
RiveFileFactory.getBackend() === 'experimental';

example/__tests__/viewmodel-instance-lookup.harness.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,8 @@ import {
1717
import type { ViewModelInstance } from '@rive-app/react-native';
1818

1919
// rive-android experimental SDK doesn't expose the ViewModel name from
20-
// DefaultForArtboard yet (pending rive-app/rive-android#443).
20+
// DefaultForArtboard yet — pending rive-app/rive-android#443 which adds
21+
// getDefaultViewModelInfo(). Once merged and released, remove these guards.
2122
const isAndroidExperimental =
2223
Platform.OS === 'android' && RiveFileFactory.getBackend() === 'experimental';
2324

0 commit comments

Comments
 (0)