Commit 6244b2e
authored
feat: add getPropertyCountAsync and getInstanceCountAsync and deprecate propertyCount and instanceCount (#198)
## Summary
- Add `getPropertyCountAsync()` and `getInstanceCountAsync()` async
methods to `ViewModel`
- Deprecate sync `propertyCount` and `instanceCount` properties — the
experimental Rive runtime requires async calls, and sync versions use
blocking wrappers that can deadlock on the main thread
- Legacy implementations wrap the existing sync getters in
`Promise.async`
- Update harness test to use async methods
## Test plan
- [x] Run `databinding-advanced` harness tests on iOS and Android1 parent e9779d2 commit 6244b2e
File tree
12 files changed
+130
-9
lines changed- android/src/main/java/com/margelo/nitro/rive
- example/__tests__
- ios
- nitrogen/generated
- android
- c++
- kotlin/com/margelo/nitro/rive
- ios
- c++
- swift
- src/specs
12 files changed
+130
-9
lines changedLines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
53 | 53 | | |
54 | 54 | | |
55 | 55 | | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
| 63 | + | |
56 | 64 | | |
57 | 65 | | |
58 | 66 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
73 | 73 | | |
74 | 74 | | |
75 | 75 | | |
76 | | - | |
77 | | - | |
78 | | - | |
| 76 | + | |
| 77 | + | |
79 | 78 | | |
80 | 79 | | |
81 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
41 | 41 | | |
42 | 42 | | |
43 | 43 | | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
44 | 52 | | |
45 | 53 | | |
46 | 54 | | |
| |||
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 8 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Lines changed: 38 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.
0 commit comments