Skip to content

Conversation

@jog1t
Copy link
Collaborator

@jog1t jog1t commented Jan 17, 2026

TL;DR

Updated client build configuration to support more flexible output directory management.

What changed?

  • Changed default client output directory from dist to public
  • Added new emptyOutDir option to control whether the output directory is cleared before build
  • Removed path joining logic that previously nested client output in a public subfolder
  • Added new configuration options in SrvxOptions interface to control client output directory and emptying behavior
  • Updated ClientBuildOptions interface with improved documentation

How to test?

  1. Build a project with default settings and verify output goes to public directory
  2. Test with custom output directory: srvx({ clientOutDir: 'custom-dir' })
  3. Test with clientEmptyOutDir: false to verify existing files are preserved during build

Why make this change?

This change provides more flexibility for deployment configurations by:

  1. Using a more standard public directory as the default output
  2. Allowing developers to control whether the output directory is emptied before builds
  3. Providing direct control over client output location without forcing a nested structure
  4. Making the configuration more intuitive with better documentation

@jog1t jog1t marked this pull request as ready for review January 17, 2026 03:43
Copy link
Collaborator Author

jog1t commented Jan 17, 2026

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 17, 2026

Open in StackBlitz

npm i https://pkg.pr.new/rivet-dev/vite-plugin-srvx@4

commit: 71750c2

@jog1t jog1t force-pushed the 01-17-fix_output_files_to_correct_directory branch from ecce964 to 71750c2 Compare January 17, 2026 03:58
@jog1t jog1t merged commit 74dabf9 into main Jan 17, 2026
4 checks passed
@jog1t jog1t deleted the 01-17-fix_output_files_to_correct_directory branch January 17, 2026 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants