add loading indicator

Author: riyhs

app/src/main/java/com/riyaldi/gamekuy/detail/DetailActivity.kt

@@ -5,6 +5,7 @@ import android.widget.Toast
 import androidx.activity.viewModels
 import androidx.appcompat.app.AppCompatActivity
 import androidx.core.content.ContextCompat
+import androidx.core.view.isVisible
 import com.bumptech.glide.Glide
 import com.google.android.material.appbar.AppBarLayout
 import com.riyaldi.core.data.Resource
@@ -38,17 +39,21 @@ class DetailActivity : AppCompatActivity(), AppBarLayout.OnOffsetChangedListener
         if (game != null) {
             detailViewModel.getDetailFilm(game.id).observe(this, { detailGame ->
                 when(detailGame) {
-                    is Resource.Loading -> Toast.makeText(this, "load", Toast.LENGTH_SHORT).show()
+                    is Resource.Loading -> showLoading(true)
                     is Resource.Success -> {
                         val dataGame = detailGame.data as Game
                         setFavoriteState(dataGame.isFavorite)
                         populateData(dataGame)
+                        showLoading(false)
                         binding.fabAddFavorite.setOnClickListener {
                             detailViewModel.setFavoriteGame(dataGame)
                             setFavoriteState(dataGame.isFavorite)
                         }
                     }
-                    is Resource.Error -> Toast.makeText(this, "error : ${detailGame.message}", Toast.LENGTH_SHORT).show()
+                    is Resource.Error -> {
+                        Toast.makeText(this, "error : ${detailGame.message}", Toast.LENGTH_SHORT).show()
+                        showLoading(false)
+                    }
                 }
             })
 
@@ -71,6 +76,12 @@ class DetailActivity : AppCompatActivity(), AppBarLayout.OnOffsetChangedListener
             .into(binding.backdrop)
     }
 
+    private fun showLoading(state: Boolean) {
+        binding.pbDetail.isVisible = state
+        binding.appbar.isVisible = !state
+        binding.nsvDetail.isVisible = !state
+    }
+
     private val percentageToShowImage = 20
     private var mMaxScrollSize = 0
     private var mIsImageHidden = false

app/src/main/java/com/riyaldi/gamekuy/explore/ExploreFragment.kt

@@ -8,6 +8,7 @@ import android.util.TypedValue
 import android.view.*
 import android.widget.Toast
 import androidx.appcompat.widget.SearchView
+import androidx.core.view.isVisible
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.viewModels
 import androidx.lifecycle.lifecycleScope
@@ -44,6 +45,7 @@ class ExploreFragment : Fragment() {
 
         if (activity != null) {
             setHasOptionsMenu(true)
+            showLoading(false)
 
             gameAdapter = GameAdapter()
 
@@ -86,12 +88,15 @@ class ExploreFragment : Fragment() {
                         exploreViewModel.games.observe(viewLifecycleOwner, { games ->
                             if (games != null) {
                                 when(games) {
-                                    is Resource.Loading -> Toast.makeText(context, "load", Toast.LENGTH_SHORT).show()
+                                    is Resource.Loading -> showLoading(true)
                                     is Resource.Success -> {
-                                        Toast.makeText(context, "success", Toast.LENGTH_SHORT).show()
                                         gameAdapter.setData(games.data)
+                                        showLoading(false)
+                                    }
+                                    is Resource.Error -> {
+                                        Toast.makeText(context, "error", Toast.LENGTH_SHORT).show()
+                                        showLoading(false)
                                     }
-                                    is Resource.Error -> Toast.makeText(context, "error", Toast.LENGTH_SHORT).show()
                                 }
                             }
                         })
@@ -106,6 +111,11 @@ class ExploreFragment : Fragment() {
         })
     }
 
+    private fun showLoading(state: Boolean) {
+        binding.pbExplore.isVisible = state
+        binding.rvExplore.isVisible = !state
+    }
+
     override fun onDestroy() {
         super.onDestroy()
         _binding = null

app/src/main/java/com/riyaldi/gamekuy/home/HomeFragment.kt

@@ -2,12 +2,12 @@ package com.riyaldi.gamekuy.home
 
 import android.content.Intent
 import android.os.Bundle
-import android.util.Log
 import android.util.TypedValue
 import android.view.LayoutInflater
 import android.view.View
 import android.view.ViewGroup
 import android.widget.Toast
+import androidx.core.view.isVisible
 import androidx.fragment.app.Fragment
 import androidx.fragment.app.viewModels
 import androidx.recyclerview.widget.LinearLayoutManager
@@ -47,11 +47,15 @@ class HomeFragment : Fragment() {
             homeViewModel.game.observe(viewLifecycleOwner, { game ->
                 if (game != null) {
                     when(game) {
-                        is Resource.Loading -> Log.d("HomeFragment", "loading")
+                        is Resource.Loading -> showLoading(true)
                         is Resource.Success -> {
                             gameAdapter.setData(game.data)
+                            showLoading(false)
+                        }
+                        is Resource.Error -> {
+                            Toast.makeText(context, "error ${game.message}", Toast.LENGTH_SHORT).show()
+                            showLoading(false)
                         }
-                        is Resource.Error -> Toast.makeText(context, "error ${game.message}", Toast.LENGTH_SHORT).show()
                     }
                 }
             })
@@ -68,6 +72,11 @@ class HomeFragment : Fragment() {
 
     }
 
+    private fun showLoading(state: Boolean) {
+        binding.pbHome.isVisible = state
+        binding.rvHome.isVisible = !state
+    }
+
     override fun onDestroy() {
         super.onDestroy()
         _binding = null

app/src/main/res/layout/activity_detail.xml

@@ -7,6 +7,14 @@
     android:layout_height="match_parent"
     android:fitsSystemWindows="true">
 
+    <ProgressBar
+        android:id="@+id/pb_detail"
+        style="?android:attr/progressBarStyle"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center"
+        android:elevation="10dp" />
+
     <com.google.android.material.appbar.AppBarLayout
         android:id="@+id/appbar"
         android:layout_width="match_parent"
@@ -45,10 +53,12 @@
                 android:layout_height="?attr/actionBarSize"
                 app:layout_collapseMode="pin"
                 app:title="Test" />
+
         </com.google.android.material.appbar.CollapsingToolbarLayout>
     </com.google.android.material.appbar.AppBarLayout>
 
     <androidx.core.widget.NestedScrollView
+        android:id="@+id/nsv_detail"
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:background="@color/black"

app/src/main/res/layout/fragment_explore.xml

@@ -2,11 +2,19 @@
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     android:layout_width="match_parent"
-    android:layout_height="match_parent">
+    android:layout_height="match_parent"
+    android:background="@color/black">
 
 
     <androidx.recyclerview.widget.RecyclerView
         android:id="@+id/rv_explore"
         android:layout_width="match_parent"
         android:layout_height="match_parent" />
+
+    <ProgressBar
+        android:id="@+id/pb_explore"
+        style="?android:attr/progressBarStyle"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center" />
 </FrameLayout>

app/src/main/res/layout/fragment_home.xml

@@ -10,4 +10,11 @@
         android:id="@+id/rv_home"
         android:layout_width="match_parent"
         android:layout_height="match_parent" />
+
+    <ProgressBar
+        android:id="@+id/pb_home"
+        style="?android:attr/progressBarStyle"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:layout_gravity="center" />
 </FrameLayout>

core/src/main/java/com/riyaldi/core/data/source/remote/response/GameResponse.kt

@@ -8,11 +8,11 @@ data class GameResponse(
     @SerializedName("name")
     val name: String,
     @SerializedName("released")
-    val released: String,
+    val released: String?,
     @SerializedName("background_image")
-    val backgroundImage: String,
+    val backgroundImage: String?,
     @SerializedName("metacritic")
-    val metacritic: Int,
+    val metacritic: Int?,
     @SerializedName("platforms")
     val platforms: List<Platforms>?,
     @SerializedName("genres")