implementing reviewer advices

Author: riyhs

app/build.gradle

@@ -9,7 +9,7 @@ apply from: '../shared_dependencies.gradle'
 
 android {
     compileSdkVersion 30
-    buildToolsVersion "30.0.2"
+    buildToolsVersion "30.0.3"
 
     defaultConfig {
         applicationId "com.riyaldi.gamekuy"

app/src/main/java/com/riyaldi/gamekuy/App.kt

@@ -4,4 +4,4 @@ import android.app.Application
 import dagger.hilt.android.HiltAndroidApp
 
 @HiltAndroidApp
-open class App: Application()
+class App: Application()

app/src/main/java/com/riyaldi/gamekuy/explore/ExploreFragment.kt

@@ -29,7 +29,7 @@ class ExploreFragment : Fragment() {
     private val exploreViewModel: ExploreViewModel by viewModels()
 
     private var _binding: FragmentExploreBinding? = null
-    private val binding get() = _binding!!
+    private val binding get() = _binding as FragmentExploreBinding
 
     private lateinit var gameAdapter: GameAdapter
 
@@ -60,6 +60,23 @@ class ExploreFragment : Fragment() {
                 startActivity(intent)
             }
 
+            exploreViewModel.games.observe(viewLifecycleOwner, { games ->
+                if (games != null) {
+                    when(games) {
+                        is Resource.Loading -> showLoading(true)
+                        is Resource.Success -> {
+                            gameAdapter.setData(games.data)
+                            showLoading(false)
+                        }
+                        is Resource.Error -> {
+                            showNoGame(true)
+                            Toast.makeText(context, "error", Toast.LENGTH_SHORT).show()
+                            showLoading(false)
+                        }
+                    }
+                }
+            })
+
             val marginVertical = TypedValue.applyDimension(TypedValue.COMPLEX_UNIT_DIP, 16f, resources.displayMetrics)
 
             with(binding.rvExplore){
@@ -90,22 +107,6 @@ class ExploreFragment : Fragment() {
                 if (query != null) {
                     lifecycleScope.launch {
                         exploreViewModel.searchGames(query)
-                        exploreViewModel.games.observe(viewLifecycleOwner, { games ->
-                            if (games != null) {
-                                when(games) {
-                                    is Resource.Loading -> showLoading(true)
-                                    is Resource.Success -> {
-                                        gameAdapter.setData(games.data)
-                                        showLoading(false)
-                                    }
-                                    is Resource.Error -> {
-                                        showNoGame(true)
-                                        Toast.makeText(context, "error", Toast.LENGTH_SHORT).show()
-                                        showLoading(false)
-                                    }
-                                }
-                            }
-                        })
                     }
                 }
                 return true

app/src/main/java/com/riyaldi/gamekuy/home/HomeFragment.kt

@@ -25,7 +25,7 @@ class HomeFragment : Fragment() {
     private val homeViewModel: HomeViewModel by viewModels()
 
     private var _binding: FragmentHomeBinding? = null
-    private val binding get() = _binding!!
+    private val binding get() = _binding as FragmentHomeBinding
 
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
         _binding = FragmentHomeBinding.inflate(inflater, container, false)

core/build.gradle

@@ -8,7 +8,7 @@ apply from: '../shared_dependencies.gradle'
 
 android {
     compileSdkVersion 30
-    buildToolsVersion "30.0.2"
+    buildToolsVersion "30.0.3"
 
     defaultConfig {
         minSdkVersion 23

core/src/main/java/com/riyaldi/core/data/source/local/entity/GameEntity.kt

@@ -1,13 +1,10 @@
 package com.riyaldi.core.data.source.local.entity
 
-import android.os.Parcelable
 import androidx.annotation.NonNull
 import androidx.room.ColumnInfo
 import androidx.room.Entity
 import androidx.room.PrimaryKey
-import kotlinx.parcelize.Parcelize
 
-@Parcelize
 @Entity(tableName = "tb_game")
 data class GameEntity(
     @PrimaryKey
@@ -41,4 +38,4 @@ data class GameEntity(
 
     @ColumnInfo(name = "isFavorite")
     var isFavorite: Boolean
-) : Parcelable
+)

core/src/main/res/layout/item_list_layout.xml

@@ -20,7 +20,7 @@
             android:layout_width="0dp"
             android:layout_height="225dp"
             android:adjustViewBounds="true"
-            android:contentDescription="Description"
+            android:contentDescription="@string/description"
             android:scaleType="centerCrop"
             app:layout_constraintEnd_toEndOf="parent"
             app:layout_constraintStart_toStartOf="parent"
@@ -34,7 +34,7 @@
             android:layout_marginStart="16dp"
             android:layout_marginTop="8dp"
             android:layout_marginEnd="16dp"
-            android:text="TextView"
+            android:text="@string/textview"
             android:textColor="@android:color/primary_text_dark"
             android:textSize="24sp"
             android:textStyle="bold"
@@ -50,7 +50,7 @@
             android:layout_marginTop="8dp"
             android:layout_marginEnd="16dp"
             android:layout_marginBottom="16dp"
-            android:text="TextView"
+            android:text="@string/textview"
             android:textColor="@android:color/primary_text_dark"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintEnd_toEndOf="parent"
@@ -65,7 +65,7 @@
             android:layout_marginEnd="16dp"
             android:ellipsize="end"
             android:maxLines="1"
-            android:text="TextView"
+            android:text="@string/textview"
             android:textColor="@android:color/primary_text_dark"
             app:layout_constraintBottom_toBottomOf="@+id/metascore"
             app:layout_constraintEnd_toStartOf="@+id/metascore"
@@ -88,7 +88,7 @@
                 android:id="@+id/tv_item_metascore"
                 android:layout_width="wrap_content"
                 android:layout_height="wrap_content"
-                android:text="99"
+                android:text="@string/_99"
                 android:textColor="@color/green"
                 android:textSize="14sp"
                 android:textStyle="bold" />

core/src/main/res/values/strings.xml

@@ -0,0 +1,6 @@
+<?xml version="1.0" encoding="utf-8"?>
+<resources>
+    <string name="description">Description</string>
+    <string name="textview">TextView</string>
+    <string name="_99">99</string>
+</resources>

favorite/build.gradle

@@ -8,7 +8,7 @@ apply from: '../shared_dependencies.gradle'
 
 android {
     compileSdkVersion 30
-    buildToolsVersion "30.0.2"
+    buildToolsVersion "30.0.3"
 
     defaultConfig {
         applicationId "com.riyaldi.gamekuy.favorite"

favorite/src/main/java/com/riyaldi/gamekuy/favorite/ui/FavoriteFragment.kt

@@ -31,7 +31,7 @@ class FavoriteFragment : Fragment() {
     }
 
     private var _binding: FragmentFavoriteBinding? = null
-    private val binding get() = _binding!!
+    private val binding get() = _binding as FragmentFavoriteBinding
 
     override fun onCreateView(inflater: LayoutInflater, container: ViewGroup?, savedInstanceState: Bundle?): View {
         _binding = FragmentFavoriteBinding.inflate(inflater, container, false)