optimize

riyhs · riyhs · commit af40da0f789f · 2021-02-23T23:18:52.000+07:00
diff --git a/app/src/main/java/com/riyaldi/gamekuy/explore/ExploreViewModel.kt b/app/src/main/java/com/riyaldi/gamekuy/explore/ExploreViewModel.kt
@@ -5,7 +5,6 @@ import androidx.lifecycle.LiveData
 import androidx.lifecycle.MutableLiveData
 import androidx.lifecycle.ViewModel
 import com.riyaldi.core.data.Resource
-import com.riyaldi.core.data.source.local.entity.GameEntity
 import com.riyaldi.core.domain.model.Game
 import com.riyaldi.core.domain.usecase.GameUseCase
 
diff --git a/app/src/main/res/layout/activity_detail.xml b/app/src/main/res/layout/activity_detail.xml
@@ -1,10 +1,10 @@
 <?xml version="1.0" encoding="utf-8"?>
-<androidx.coordinatorlayout.widget.CoordinatorLayout
-    xmlns:android="http://schemas.android.com/apk/res/android"
+<androidx.coordinatorlayout.widget.CoordinatorLayout xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
+    android:background="@color/black"
     android:fitsSystemWindows="true">
 
     <ProgressBar
@@ -25,10 +25,10 @@
             android:id="@+id/collapsing"
             android:layout_width="match_parent"
             android:layout_height="match_parent"
-            app:layout_scrollFlags="scroll|exitUntilCollapsed"
             app:contentScrim="?attr/colorPrimary"
-            app:expandedTitleMarginStart="48dp"
             app:expandedTitleMarginEnd="64dp"
+            app:expandedTitleMarginStart="48dp"
+            app:layout_scrollFlags="scroll|exitUntilCollapsed"
             app:maxLines="2"
             app:title="@string/app_name">
 
diff --git a/assets/undraw_gaming.svg b/assets/undraw_gaming.svg
diff --git a/assets/undraw_old_day.svg b/assets/undraw_old_day.svg
diff --git a/assets/undraw_old_day.webp b/assets/undraw_old_day.webp
diff --git a/assets/undraw_virtual_reality.svg b/assets/undraw_virtual_reality.svg
diff --git a/core/src/main/AndroidManifest.xml b/core/src/main/AndroidManifest.xml
@@ -1,5 +1,4 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    package="com.riyaldi.core">
+<manifest package="com.riyaldi.core">
 
 </manifest>
diff --git a/core/src/main/java/com/riyaldi/core/data/source/remote/network/ApiService.kt b/core/src/main/java/com/riyaldi/core/data/source/remote/network/ApiService.kt
@@ -2,7 +2,6 @@ package com.riyaldi.core.data.source.remote.network
 
 import com.riyaldi.core.data.source.remote.response.GameResponse
 import com.riyaldi.core.data.source.remote.response.GamesResponse
-import retrofit2.Call
 import retrofit2.http.GET
 import retrofit2.http.Path
 import retrofit2.http.Query
diff --git a/core/src/main/java/com/riyaldi/core/di/RepositoryModule.kt b/core/src/main/java/com/riyaldi/core/di/RepositoryModule.kt
@@ -13,4 +13,5 @@ abstract class RepositoryModule {
 
     @Binds
     abstract fun provideRepository(gameRepository: GameRepositoryImpl): GameRepository
+
 }
diff --git a/core/src/main/java/com/riyaldi/core/domain/repository/GameRepository.kt b/core/src/main/java/com/riyaldi/core/domain/repository/GameRepository.kt
@@ -1,7 +1,6 @@
 package com.riyaldi.core.domain.repository
 
 import com.riyaldi.core.data.Resource
-import com.riyaldi.core.data.source.local.entity.GameEntity
 import com.riyaldi.core.domain.model.Game
 import kotlinx.coroutines.flow.Flow
 
diff --git a/core/src/main/java/com/riyaldi/core/domain/usecase/GameUseCase.kt b/core/src/main/java/com/riyaldi/core/domain/usecase/GameUseCase.kt
@@ -1,7 +1,6 @@
 package com.riyaldi.core.domain.usecase
 
 import com.riyaldi.core.data.Resource
-import com.riyaldi.core.data.source.local.entity.GameEntity
 import com.riyaldi.core.domain.model.Game
 import kotlinx.coroutines.flow.Flow
 
diff --git a/core/src/main/java/com/riyaldi/core/domain/usecase/GameUseCaseImpl.kt b/core/src/main/java/com/riyaldi/core/domain/usecase/GameUseCaseImpl.kt
@@ -1,10 +1,8 @@
 package com.riyaldi.core.domain.usecase
 
 import com.riyaldi.core.data.Resource
-import com.riyaldi.core.data.source.local.entity.GameEntity
 import com.riyaldi.core.domain.model.Game
 import com.riyaldi.core.domain.repository.GameRepository
-import kotlinx.coroutines.flow.Flow
 import javax.inject.Inject
 
 class GameUseCaseImpl @Inject constructor(private val gameRepository: GameRepository): GameUseCase {
diff --git a/core/src/main/java/com/riyaldi/core/utils/AppExecutors.kt b/core/src/main/java/com/riyaldi/core/utils/AppExecutors.kt
@@ -1,40 +1,20 @@
 package com.riyaldi.core.utils
 
-import android.os.Handler
-import android.os.Looper
 import androidx.annotation.VisibleForTesting
 import java.util.concurrent.Executor
 import java.util.concurrent.Executors
 import javax.inject.Inject
 
 class AppExecutors @VisibleForTesting constructor(
-    private val diskIO: Executor,
-    private val networkIO: Executor,
-    private val mainThread: Executor
+        private val diskIO: Executor
 ) {
-    companion object {
-        private const val THREAD_COUNT = 3
-    }
+    companion object;
 
     @Inject
     constructor() : this(
-        Executors.newSingleThreadExecutor(),
-        Executors.newFixedThreadPool(THREAD_COUNT),
-        MainThreadExecutor()
+            Executors.newSingleThreadExecutor()
     )
 
     fun diskIO(): Executor = diskIO
 
-    fun networkIO(): Executor = networkIO
-
-    fun mainThread(): Executor = mainThread
-
-    private class MainThreadExecutor: Executor {
-        private val mainThreadHandler = Handler(Looper.getMainLooper())
-
-        override fun execute(command: Runnable) {
-            mainThreadHandler.post(command)
-        }
-
-    }
 }
diff --git a/favorite/src/main/AndroidManifest.xml b/favorite/src/main/AndroidManifest.xml
@@ -1,6 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
-<manifest xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:dist="http://schemas.android.com/apk/distribution"
+<manifest xmlns:dist="http://schemas.android.com/apk/distribution"
     package="com.riyaldi.gamekuy.favorite">
 
     <dist:module
diff --git a/favorite/src/main/res/drawable/ic_undraw_gaming.xml b/favorite/src/main/res/drawable/ic_undraw_gaming.xml
@@ -1,5 +1,6 @@
 <vector xmlns:android="http://schemas.android.com/apk/res/android"
     xmlns:aapt="http://schemas.android.com/aapt"
+    xmlns:tools="http://schemas.android.com/tools"
     android:width="976.68dp"
     android:height="840.3dp"
     android:viewportWidth="976.68"
@@ -8,7 +9,8 @@
       android:pathData="M890.34,455.97c-37.95,64.71 -32.78,151.72 -18,220.09 4.94,22.89 10.69,47 5.57,72.88 -6.26,31.6 -27.3,56.75 -48.39,71.31 -38.44,26.55 -81.74,26.74 -112.74,0.5 -26.79,-22.68 -43.93,-62.84 -71.32,-84.27 -45.83,-35.85 -110.08,-12.18 -166.21,23.41 -39.71,25.18 -83.48,56.95 -119.38,40.25 -25.26,-11.75 -40.48,-46.09 -47.16,-83.67 -3.23,-18.14 -5,-38 -12.95,-51.71 -4.73,-8.15 -11.34,-13.53 -18.21,-17.91 -62.77,-40 -149.46,-3.61 -209.85,-49.08 -40.79,-30.71 -63.06,-95.42 -69.43,-165s1.45,-144.33 10.86,-218c6.69,-52.33 15.46,-108.4 41.74,-151.41 27.8,-45.5 70.64,-66.46 107.44,-63s68.34,28 95.35,58.18c33.75,37.74 63.91,86.2 108.32,97.67 30.25,7.81 63.66,-2.67 96.08,-8.89 54.19,-10.4 107.39,-8.86 160.2,-6.5 50.56,2.26 101.41,5.34 148.2,23.55 33.11,12.89 58.17,40.64 89,58.38 20.07,11.56 42.95,12.6 61.55,28.19 22.92,19.21 42.37,55.15 32.14,101.3C943.42,396.15 910.52,421.62 890.34,455.97Z"
       android:strokeAlpha="0.1"
       android:fillColor="#6283ff"
-      android:fillAlpha="0.1"/>
+      android:fillAlpha="0.1"
+      tools:ignore="VectorPath" />
   <path
       android:pathData="M162.75,659.98s-66.72,-110.51 -48,-209.67c7.87,-41.62 2.81,-84.68 -15.86,-122.7a329,329 0,0 0,-31.43 -51.3"
       android:strokeWidth="2"
@@ -62,7 +64,8 @@
       android:fillColor="#6283ff"
       android:fillAlpha="0.1"/>
   <path
-      android:pathData="M909.65,644.31s-0.8,-1.07 -1.91,-2.27l0.32,-0.11s-14.28,-35.69 -11.1,-50.76 -12.69,-51.55 -12.69,-51.55 -23.41,-47.94 -12.33,-86.2a102.72,102.72 0,0 0,2.86 -13.73c3.31,-22.66 2.14,-27.33 -3.41,-35.61l-0.61,-0.89a7,7 0,0 0,1.59 -2.35C877.13,388.15 850.17,365.15 857.34,343.73c6.62,-19.85 -10.61,-60.81 -13.17,-66.7l0,0 -0.29,-0.67 -0.86,0.28a20.92,20.92 0,0 1,5.66 -13.73l0.16,-0.16c2.38,-2.19 5.27,-3.8 7.5,-6.15l0.13,-0.15c0.22,-0.21 0.45,-0.42 0.66,-0.64 2.21,-2.32 3.72,-5.76 2.52,-8.74 -1.09,-2.72 -4.15,-4.38 -4.87,-7.22a37.15,37.15 0,0 1,-0.32 -3.85c-0.58,-4 -4.47,-6.51 -8,-8.49 -4.39,-2.48 -9,-5 -14.07,-5.06 -6.86,0 -13,4.6 -19.81,5.17 -2.32,0.2 -4.73,-0.08 -6.93,0.69a15.43,15.43 0,0 0,-4.55 2.92,22.38 22.38,0 0,0 -2.22,2c-1.54,1.44 -2.85,3.14 -2.79,5.18a5.64,5.64 0,0 0,1.94 3.85,25.38 25.38,0 0,0 9.19,37.78c0.08,0.55 0.16,1.11 0.24,1.7 1,7.51 1.59,18.13 -1.08,26.45 -11.39,5.87 -29.14,15.44 -32.32,19.69a3,3 0,0 0,-0.42 2.49,3.39 3.39,0 0,0 -0.06,1.19c-2.49,0.57 -5.8,0 -9.83,-3.68 -9.52,-8.72 -39.65,-34.9 -39.65,-34.9s-13.48,-33.31 -23,-27 11.1,37.28 11.1,37.28L757.34,351.66s1.59,10.31 18.24,4.76c5.5,-1.83 10.47,-3.58 14.67,-5.09l1,0.85c-3.75,21.94 -5.69,51.18 8.14,59.76a13.38,13.38 0,0 1,2.3 4.82c-0.07,0.26 -0.14,0.53 -0.2,0.79a76.15,76.15 0,0 0,-2 13.34,42.42 42.42,0 0,0 -3.51,18.94l-5.3,75.51s-0.79,16.65 4.76,29.34 23,76.14 11.1,80.9l1.13,0.15c-3.41,3.51 -9.15,8.83 -13.52,9.88 -6.64,1.58 -4.78,11.76 9.94,13.46s16.49,1.56 26.84,-7.07c9.12,-7.6 10.57,-11 10.78,-11.73l0.52,0.07s-5.55,-20.62 0,-29.34S829.55,549.15 829.55,549.15a171.47,171.47 0,0 1,0.75 -20.34c2.8,7.33 4.8,12.41 4.8,12.41s4.76,23 10.31,27 34.9,58.69 30.14,82.48l-0.55,2.77 1.34,-0.39 0.12,0c-1.83,4.53 -5.16,11.69 -8.84,14.32 -5.55,4 0,12.69 14.28,8.72s15.86,-4.76 22.21,-16.65S909.65,644.31 909.65,644.31Z">
+      android:pathData="M909.65,644.31s-0.8,-1.07 -1.91,-2.27l0.32,-0.11s-14.28,-35.69 -11.1,-50.76 -12.69,-51.55 -12.69,-51.55 -23.41,-47.94 -12.33,-86.2a102.72,102.72 0,0 0,2.86 -13.73c3.31,-22.66 2.14,-27.33 -3.41,-35.61l-0.61,-0.89a7,7 0,0 0,1.59 -2.35C877.13,388.15 850.17,365.15 857.34,343.73c6.62,-19.85 -10.61,-60.81 -13.17,-66.7l0,0 -0.29,-0.67 -0.86,0.28a20.92,20.92 0,0 1,5.66 -13.73l0.16,-0.16c2.38,-2.19 5.27,-3.8 7.5,-6.15l0.13,-0.15c0.22,-0.21 0.45,-0.42 0.66,-0.64 2.21,-2.32 3.72,-5.76 2.52,-8.74 -1.09,-2.72 -4.15,-4.38 -4.87,-7.22a37.15,37.15 0,0 1,-0.32 -3.85c-0.58,-4 -4.47,-6.51 -8,-8.49 -4.39,-2.48 -9,-5 -14.07,-5.06 -6.86,0 -13,4.6 -19.81,5.17 -2.32,0.2 -4.73,-0.08 -6.93,0.69a15.43,15.43 0,0 0,-4.55 2.92,22.38 22.38,0 0,0 -2.22,2c-1.54,1.44 -2.85,3.14 -2.79,5.18a5.64,5.64 0,0 0,1.94 3.85,25.38 25.38,0 0,0 9.19,37.78c0.08,0.55 0.16,1.11 0.24,1.7 1,7.51 1.59,18.13 -1.08,26.45 -11.39,5.87 -29.14,15.44 -32.32,19.69a3,3 0,0 0,-0.42 2.49,3.39 3.39,0 0,0 -0.06,1.19c-2.49,0.57 -5.8,0 -9.83,-3.68 -9.52,-8.72 -39.65,-34.9 -39.65,-34.9s-13.48,-33.31 -23,-27 11.1,37.28 11.1,37.28L757.34,351.66s1.59,10.31 18.24,4.76c5.5,-1.83 10.47,-3.58 14.67,-5.09l1,0.85c-3.75,21.94 -5.69,51.18 8.14,59.76a13.38,13.38 0,0 1,2.3 4.82c-0.07,0.26 -0.14,0.53 -0.2,0.79a76.15,76.15 0,0 0,-2 13.34,42.42 42.42,0 0,0 -3.51,18.94l-5.3,75.51s-0.79,16.65 4.76,29.34 23,76.14 11.1,80.9l1.13,0.15c-3.41,3.51 -9.15,8.83 -13.52,9.88 -6.64,1.58 -4.78,11.76 9.94,13.46s16.49,1.56 26.84,-7.07c9.12,-7.6 10.57,-11 10.78,-11.73l0.52,0.07s-5.55,-20.62 0,-29.34S829.55,549.15 829.55,549.15a171.47,171.47 0,0 1,0.75 -20.34c2.8,7.33 4.8,12.41 4.8,12.41s4.76,23 10.31,27 34.9,58.69 30.14,82.48l-0.55,2.77 1.34,-0.39 0.12,0c-1.83,4.53 -5.16,11.69 -8.84,14.32 -5.55,4 0,12.69 14.28,8.72s15.86,-4.76 22.21,-16.65S909.65,644.31 909.65,644.31Z"
+      tools:ignore="VectorPath">
     <aapt:attr name="android:fillColor">
       <gradient 
           android:startY="677.05"
diff --git a/favorite/src/main/res/layout/fragment_favorite.xml b/favorite/src/main/res/layout/fragment_favorite.xml
@@ -1,11 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <FrameLayout xmlns:android="http://schemas.android.com/apk/res/android"
-    xmlns:app="http://schemas.android.com/apk/res-auto"
     xmlns:tools="http://schemas.android.com/tools"
     android:layout_width="match_parent"
     android:layout_height="match_parent"
     android:background="@color/black"
-    tools:context=".ui.FavoriteFragment">
+    tools:context=".ui.FavoriteFragment"
+    tools:ignore="Overdraw">
 
     <androidx.recyclerview.widget.RecyclerView
         android:id="@+id/rv_favorite"
@@ -17,7 +17,8 @@
         android:layout_width="match_parent"
         android:layout_height="match_parent"
         android:layout_margin="48dp"
-        android:src="@drawable/ic_undraw_gaming" />
+        android:src="@drawable/ic_undraw_gaming"
+        tools:ignore="ContentDescription" />
 
     <TextView
         android:id="@+id/tv_no_fav_games"
@@ -28,7 +29,7 @@
         android:layout_marginTop="175dp"
         android:layout_marginEnd="32dp"
         android:gravity="center"
-        android:text="You don't have any favorite games"
+        android:text="@string/you_don_t_have_any_favorite_games"
         android:textColor="@color/white"
         android:textSize="24sp"
         android:textStyle="bold" />
diff --git a/favorite/src/main/res/values/strings.xml b/favorite/src/main/res/values/strings.xml
@@ -1,4 +1,3 @@
 <resources>
-    <!-- TODO: Remove or change this placeholder text -->
-    <string name="hello_blank_fragment">Hello blank fragment</string>
+    <string name="you_don_t_have_any_favorite_games">You don\'t have any favorite games</string>
 </resources>

Original file line number	Diff line number	Diff line change
`@@ -13,4 +13,5 @@ abstract class RepositoryModule {`
`13`	`13`
`14`	`14`	`@Binds`
`15`	`15`	`abstract fun provideRepository(gameRepository: GameRepositoryImpl): GameRepository`
	`16`	`+`
`16`	`17`	`}`