implement rop.cache to store and return cached ROP search results

Author: devalgupta404

librz/arch/analysis.c

@@ -212,6 +212,7 @@ RZ_API RzAnalysis *rz_analysis_free(RzAnalysis *a) {
 	rz_str_constpool_fini(&a->constpool);
 	ht_sp_free(a->ht_global_var);
 	ht_up_free(a->ht_rop_semantics);
+	ht_up_free(a->ht_rop);
 	ht_sp_free(a->plugins);
 	rz_analysis_debug_info_free(a->debug_info);
 	ht_sp_free(a->ht_virtual_xrefs);

librz/core/rop.c

@@ -1878,6 +1878,19 @@ static int handle_rop_search_address(RzCore *core, RzRopSearchContext *context,
 RZ_API RzCmdStatus rz_core_rop_search(RZ_NONNULL RzCore *core, RZ_NONNULL RzRopSearchContext *context) {
 	rz_return_val_if_fail(core && core->search && context, RZ_CMD_STATUS_ERROR);
 
+	if (context->cache && context->greparg) {
+		if (!core->analysis->ht_rop) {
+			core->analysis->ht_rop = ht_up_new(NULL, free);
+		}
+		ut64 cache_key = rz_str_djb2_hash(context->greparg);
+		char *cached_result = ht_up_find(core->analysis->ht_rop, cache_key, NULL);
+		if (cached_result) {
+			rz_cons_print(cached_result);
+			return RZ_CMD_STATUS_OK;
+		}
+		context->ret_val = true;
+	}
+
 	RzInterval search_itv = { 0 };
 	if (!fetch_search_itv(core, &search_itv)) {
 		return RZ_CMD_STATUS_ERROR;
@@ -1944,6 +1957,18 @@ RZ_API RzCmdStatus rz_core_rop_search(RZ_NONNULL RzCore *core, RZ_NONNULL RzRopS
 		eprintf("\n");
 	}
 
+	if (context->cache && context->greparg && context->buf) {
+		ut64 cache_key = rz_str_djb2_hash(context->greparg);
+		char *result = rz_strbuf_drain(context->buf);
+		context->buf = NULL;
+		if (result && *result) {
+			ht_up_insert(core->analysis->ht_rop, cache_key, result);
+			rz_cons_print(result);
+		} else {
+			free(result);
+		}
+	}
+
 	if (context->state) {
 		rz_cmd_state_output_array_end(context->state);
 	}

test/unit/test_rop.c

@@ -141,8 +141,27 @@ bool test_rz_direct_solver() {
 	mu_end;
 }
 
+bool test_rop_cache() {
+	RzCore *core = setup_rz_core("x86", 64);
+	mu_assert_notnull(core, "setup_rz_core failed");
+	mu_assert_null(core->analysis->ht_rop, "ht_rop should be NULL initially");
+	ut8 buf[8];
+	rz_hex_str2bin("48C7C301000000C3", buf);
+	rz_io_write_at(core->io, 0, buf, 8);
+	rz_config_set_b(core->config, "rop.cache", true);
+	RzRopSearchContext *context = rz_core_rop_search_context_new(
+		core, "mov", false, RZ_ROP_GADGET_PRINT, RZ_ROP_DETAIL_SEARCH_NON, NULL);
+	RzCmdStatus status = rz_core_rop_search(core, context);
+	mu_assert_eq(status, RZ_CMD_STATUS_OK, "rop search should succeed");
+	mu_assert_notnull(core->analysis->ht_rop, "ht_rop should be initialized after cached search");
+	rz_core_rop_search_context_free(context);
+	rz_core_free(core);
+	mu_end;
+}
+
 bool all_tests() {
 	mu_run_test(test_rz_direct_solver);
+	mu_run_test(test_rop_cache);
 	return tests_passed != tests_run;
 }