Skip to content

Commit 31bb9e9

Browse files
committed
Allow resolveTransportVersionConflict to run on release branches
Transport version generation must only happen on the main branch. The resolveTransportVersionConflict task exists to deal with merge conflicts when syncing a PR with main. However, conflicts can also arise when cherry-picking a commit for backport. This commit updates the task to also handle cherry picks to older branches.
1 parent da6d514 commit 31bb9e9

File tree

3 files changed

+14
-6
lines changed

3 files changed

+14
-6
lines changed

build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/AbstractTransportVersionFuncTest.groovy

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -167,6 +167,10 @@ class AbstractTransportVersionFuncTest extends AbstractGradleFuncTest {
167167
execute("git init")
168168
execute('git config user.email "build-tool@elastic.co"')
169169
execute('git config user.name "Build tool"')
170+
file(".gitignore") << """
171+
.gradle/
172+
build/
173+
""".stripIndent()
170174
execute("git add .")
171175
execute('git commit -m "Initial"')
172176
}

build-tools-internal/src/integTest/groovy/org/elasticsearch/gradle/internal/transport/ResolveTransportVersionConflictFuncTest.groovy

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -145,11 +145,6 @@ class ResolveTransportVersionConflictFuncTest extends AbstractTransportVersionFu
145145

146146
def "resolve on release branch accepts upstream"() {
147147
given:
148-
file("myserver/build.gradle") << """
149-
tasks.named('resolveTransportVersionConflict') {
150-
currentUpperBoundName = '9.1'
151-
}
152-
"""
153148
// setup main with 2 commits, but we will only cherry pick the second one
154149
execute("git checkout main")
155150
referableAndReferencedTransportVersion("upstream_new_tv1", "8124000")
@@ -163,6 +158,15 @@ class ResolveTransportVersionConflictFuncTest extends AbstractTransportVersionFu
163158
execute("git commit -m update2")
164159
String toCherryPick = execute("git rev-parse HEAD")
165160
execute("git checkout test") // test is a faux 9.1 branch
161+
file("myserver/build.gradle") << """
162+
tasks.named('resolveTransportVersionConflict') {
163+
currentUpperBoundName = '9.1'
164+
}
165+
tasks.named('validateTransportVersionResources') {
166+
currentUpperBoundName = '9.1'
167+
}
168+
"""
169+
execute("git commit -a -m update-branch")
166170
execute("git cherry-pick " + toCherryPick, testProjectDir.root, true);
167171

168172
when:

build-tools-internal/src/main/java/org/elasticsearch/gradle/internal/transport/ResolveTransportVersionConflictTask.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ protected void runGeneration(TransportVersionResourcesService resources, List<Tr
2222

2323
if (onReleaseBranch) {
2424
if (resources.hasCherryPickConflicts()) {
25-
getLogger().lifecycle("Resolving transport version merge conflicts by checking accepting upstream changes...");
25+
getLogger().lifecycle("Resolving transport version conflicts by accepting upstream changes...");
2626
resources.checkoutOriginalChange();
2727
} else {
2828
getLogger().lifecycle("No transport version merge conflicts detected");

0 commit comments

Comments
 (0)