Skip to content

Commit 8d902c1

Browse files
craigtavernerrjernst
authored andcommitted
Fix ES|QL docs railroad diagrams comma positions for optional parameters (elastic#134298)
The SVG images in ES|QL docs had many mistakes with comma positions inside optional parameter groups. For example, the bucket command does not include the comma in the optional group, making it look like we need to type a trailing comma. Almost twenty images are fixed, while also taking care to handle commas at the end of trailing optional parameters, and complex cases like COALESCE. We also added unit tests for the RailRoadDiagram class to make it much easier to test and debug this, as well as reducing the chance that further refinements break anything.
1 parent bf32388 commit 8d902c1

File tree

23 files changed

+211
-55
lines changed

23 files changed

+211
-55
lines changed

docs/reference/query-languages/esql/images/functions/bucket.svg

Lines changed: 1 addition & 1 deletion
Loading

docs/reference/query-languages/esql/images/functions/categorize.svg

Lines changed: 1 addition & 1 deletion
Loading

docs/reference/query-languages/esql/images/functions/count_distinct.svg

Lines changed: 1 addition & 1 deletion
Loading

docs/reference/query-languages/esql/images/functions/count_distinct_over_time.svg

Lines changed: 1 addition & 1 deletion
Loading

docs/reference/query-languages/esql/images/functions/knn.svg

Lines changed: 1 addition & 1 deletion
Loading

docs/reference/query-languages/esql/images/functions/locate.svg

Lines changed: 1 addition & 1 deletion
Loading

0 commit comments

Comments
 (0)