Skip to content

Commit e1f8b51

Browse files
authored
Aggs: Comment on deprecated execution mode (elastic#122046) (elastic#122077)
This adds a comment to `execution_mode: global_ordinals_hash` explaining that we're not going to remove it so we don't break anyone.
1 parent 32bcd49 commit e1f8b51

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

server/src/main/java/org/elasticsearch/search/aggregations/bucket/terms/SignificantTermsAggregatorFactory.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -422,6 +422,10 @@ public static ExecutionMode fromString(String value, final DeprecationLogger dep
422422
if ("global_ordinals".equals(value)) {
423423
return GLOBAL_ORDINALS;
424424
} else if ("global_ordinals_hash".equals(value)) {
425+
/*
426+
* We have no plans to remove this so we don't break anyone, no matter
427+
* how few people still use this or how long it's been deprecated.
428+
*/
425429
deprecationLogger.warn(
426430
DeprecationCategory.AGGREGATIONS,
427431
"global_ordinals_hash",

0 commit comments

Comments
 (0)