Skip to content

Commit 0297a02

Browse files
committed
improvement based on feedback
1 parent f95f56c commit 0297a02

File tree

5 files changed

+16
-8
lines changed

5 files changed

+16
-8
lines changed

CHANGELOG.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,12 @@ should change the heading of the (upcoming) version to include a major version b
2222

2323
- Fixed validation regression Form not revalidating after formData change, fixing [#4343](https://github.com/rjsf-team/react-jsonschema-form/issues/4343)
2424

25+
# 5.22.1
26+
27+
## Dev / docs / playground
28+
29+
- Bumped peer dependencies to 5.22.x due to updated type definition and API changes in @rjsf/utils
30+
2531
# 5.22.0
2632

2733
## @rjsf/core

packages/core/test/ArrayField.test.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3220,7 +3220,7 @@ describe('ArrayField', () => {
32203220
});
32213221

32223222
it('Check that when formData changes, the form should re-validate', () => {
3223-
const { node, rerender, compCB } = createFormComponent({
3223+
const { node, rerender } = createFormComponent({
32243224
schema,
32253225
formData: [
32263226
{
@@ -3235,7 +3235,7 @@ describe('ArrayField', () => {
32353235
const errorMessageContent = node.querySelector('#root_0_text__error .text-danger').textContent;
32363236
expect(errorMessageContent).to.contain('must be string');
32373237

3238-
rerender(compCB({ schema, formData: [{ text: 'test' }], liveValidate: true }));
3238+
rerender({ schema, formData: [{ text: 'test' }], liveValidate: true });
32393239

32403240
expect(node.querySelectorAll('#root_0_text__error')).to.have.length(0);
32413241
});

packages/core/test/ObjectField.test.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -228,7 +228,7 @@ describe('ObjectField', () => {
228228
});
229229

230230
it('Check that when formData changes, the form should re-validate', () => {
231-
const { node, rerender, compCB } = createFormComponent({
231+
const { node, rerender } = createFormComponent({
232232
schema,
233233
formData: {
234234
foo: null,
@@ -241,7 +241,7 @@ describe('ObjectField', () => {
241241
const errorMessageContent = node.querySelector('#root_foo__error .text-danger').textContent;
242242
expect(errorMessageContent).to.contain('must be string');
243243

244-
rerender(compCB({ schema, formData: { foo: 'test' }, liveValidate: true }));
244+
rerender({ schema, formData: { foo: 'test' }, liveValidate: true });
245245

246246
expect(node.querySelectorAll('#root_foo__error')).to.have.length(0);
247247
});

packages/core/test/StringField.test.jsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ describe('StringField', () => {
300300
});
301301

302302
it('Check that when formData changes, the form should re-validate', () => {
303-
const { node, rerender, compCB } = createFormComponent({
303+
const { node, rerender } = createFormComponent({
304304
schema: { type: 'string' },
305305
formData: null,
306306
liveValidate: true,
@@ -311,7 +311,7 @@ describe('StringField', () => {
311311
const errorMessageContent = node.querySelector('#root__error .text-danger').textContent;
312312
expect(errorMessageContent).to.contain('must be string');
313313

314-
rerender(compCB({ schema: { type: 'string' }, formData: 'hello', liveValidate: true }));
314+
rerender({ schema: { type: 'string' }, formData: 'hello', liveValidate: true });
315315

316316
expect(node.querySelectorAll('#root__error')).to.have.length(0);
317317
});

packages/core/test/test_utils.js

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,11 +14,13 @@ export function createComponent(Component, props) {
1414
const onError = sinon.spy();
1515
const onSubmit = sinon.spy();
1616
const comp = <Component onSubmit={onSubmit} onError={onError} onChange={onChange} {...props} />;
17-
const compCB = (props) => <Component onSubmit={onSubmit} onError={onError} onChange={onChange} {...props} />;
1817
const { container, rerender } = render(comp);
18+
19+
const rerenderFunction = (props) =>
20+
rerender(<Component onSubmit={onSubmit} onError={onError} onChange={onChange} {...props} />);
1921
const node = findDOMNode(container).firstElementChild;
2022

21-
return { comp, compCB, node, onChange, onError, onSubmit, rerender };
23+
return { comp, node, onChange, onError, onSubmit, rerender: rerenderFunction };
2224
}
2325

2426
export function createFormComponent(props) {

0 commit comments

Comments
 (0)