Skip to content

Commit ed880d9

Browse files
authored
perf(core): using upstream useCallback dependencies are optimal
1 parent d22e271 commit ed880d9

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

packages/core/src/components/widgets/SelectWidget.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -47,23 +47,23 @@ function SelectWidget<T = any, S extends StrictRJSFSchema = RJSFSchema, F extend
4747
const newValue = getValue(event, multiple);
4848
return onFocus(id, enumOptionsValueForIndex<S>(newValue, enumOptions, optEmptyVal));
4949
},
50-
[onFocus, id, schema, multiple, options]
50+
[onFocus, id, schema, multiple, enumOptions, optEmptyVal]
5151
);
5252

5353
const handleBlur = useCallback(
5454
(event: FocusEvent<HTMLSelectElement>) => {
5555
const newValue = getValue(event, multiple);
5656
return onBlur(id, enumOptionsValueForIndex<S>(newValue, enumOptions, optEmptyVal));
5757
},
58-
[onBlur, id, schema, multiple, options]
58+
[onBlur, id, schema, multiple, enumOptions, optEmptyVal]
5959
);
6060

6161
const handleChange = useCallback(
6262
(event: ChangeEvent<HTMLSelectElement>) => {
6363
const newValue = getValue(event, multiple);
6464
return onChange(enumOptionsValueForIndex<S>(newValue, enumOptions, optEmptyVal));
6565
},
66-
[onChange, schema, multiple, options]
66+
[onChange, schema, multiple, enumOptions, optEmptyVal]
6767
);
6868

6969
const selectedIndexes = enumOptionsIndexForValue<S>(value, enumOptions, multiple);

0 commit comments

Comments
 (0)