Validation error collision when key contains dot (".") with AJV8

[rap1ds]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

5.12.1 (latest Playground)

Current Behavior

With AJV8, if a property key has a dot in it (e.g. Foo.Bar), there's a validation error collision with a Bar value inside Foo object.

Expected Behavior

There should not be collision. The behaviour should be the same as in AJV6 (deprecated)

Steps To Reproduce

Example 1

1. Open Playground example
2. Make sure AJV8 validator is selected
3. Press submit

Expected:

• Validation error "must NOT have fever than 5 characters" for value Foo
• No validation error for value Bar

Actual:

• Validation error "must NOT have fever than 5 characters" for value Foo
• Validation error "must NOT have fever than 5 characters" for value Bar

Please note that if you select AJV6 (deprecated) validator, the behaviour is as expected

Example 2

(This example is the same as above but other way around)

1. Open Playground example
2. Make sure AJV8 validator is selected
3. Press submit

Expected:

• No validation error for value FooBar
• Validation error "must NOT have fever than 2 characters" for value B

Actual:

• Validation error "must NOT have fever than 2 characters" for value FooBar
• Validation error "must NOT have fever than 2 characters" for value B

Please note: This issue happens ALSO with AJV6

Environment

- I'm using Playground, which afaik is using version 5.12.1. 
- MacOS
- Google Chrome 116.0.5845.110 (Official Build) (arm64)

Anything else?

No response

[nickgros]

In our Ajv8 validator, we're incorrectly replacing all / characters in the error's instancePath when we should probably split on the string and preserve keys that contains their own . characters. The properties will probably need to be surrounded in square brackets, just like ajv6's dataPath.

I think this is a higher priority issue for us, but with the maintainers' limited time we would appreciate any help, if you are interested in making a PR @rap1ds ?

[rap1ds]

@nickgros Thanks for your answer and pointers on how this would be fixed!

And thanks for the effort you put into maintaining the library. I totally understand that this is a low-priority issue, and maintainers have more important things on their plate.

I'm actually a ClojureScript developer myself and I'm using this library from CLJS. I have some knowledge of JavaScript but no TypeScript knowledge nor a development environment setup for TypeScript, so unfortunately, it's quite a high barrier for me to start fixing the issue. But let's see.