Wrong radio button behaviour

[AlimovSV]

Prerequisites

• I have searched the existing issues
• I understand that providing a SSCCE example is tremendously useful to the maintainers.
• I have read the documentation
• Ideally, I'm providing a sample JSFiddle, Codesandbox.io or preferably a shared playground link demonstrating the issue.

What theme are you using?

core

Version

5.24.10

Current Behavior

The radio button No is not able to be checked

Expected Behavior

Radio button No should be checkable

Steps To Reproduce

1. Open playground
2. Click to No button
3. Data is not changed, radio button No was not checked

Environment

- OS:
- Node:
- npm:

Anything else?

The same wrong behaviour you can observe if your are using "ui:widget": "select" so the original issue is not for radio only.

[nickgros]

If you add a "Yes" option, then you can select it, but "No" still does not work, so it might be that we're inappropriately checking if something is truthy/falsy

[nickgros]

Bug is in mergeDefaultsWithFormData

[nickgros]

@abdalla-rko it looks like this is caused by setting overrideFormDataWithDefaults to true in the first call to mergeDefaultsWithFormData in getDefaultFormState, which you added in #4388. Could you take a look at this regression?

[AlimovSV]

@nickgros Is it possible to publish this fix for 5.x branch?

[nickgros]

@AlimovSV Sure. We're not set up in a way that will streamline making new releases to v5, but it shouldn't be too bad. Backport PR is here: #4654

[nickgros]

@AlimovSV We just released v5.24.11 with the backported changes.

[AlimovSV]

@nickgros Thank you very much

[heath-freenome]

@AlimovSV I hope it works for you... Otherwise, consider a v6 migration soon?