Chore: Removed pre-v6 deprecations and limit react to >= 18 #4577
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickgros
reviewed
Apr 24, 2025
Comment on lines
-7
to
-8
| // @ts-expect-error -- enumNames an RJSF keyword and is not in the JSON Schema spec | ||
| enumNames: ['New York', 'Amsterdam', 'Hong Kong'], |
There was a problem hiding this comment.
Is keeping enumNames blocking anything? I would rather not remove it if we're losing this functionality (which is essential IMO).
There was a problem hiding this comment.
Also we mentioned keeping enumNames in v6 #3829 (comment) (though that was before it was ported to the UiSchema).
I think we would need to add the ability to attach a UiSchema to a definition before I would feel comfortable removing this.
There was a problem hiding this comment.
As we discussed, let's remove custom JSON Schema code to minimize the challenges for supporting newer versions
As part of v6 readiness, removed old deprecations and bumped react support to >= 18
- Updated all of the `package.json` files to change react peer dependency support to `>=18`
- Updated `Form` to remove the deprecated `acceptcharset`
- Updated the tests accordingly
- Updated `SchemaField` to remove support for the deprecated `uiSchema.classNames`
- Updated the tests accordingly
- Updated `BooleanField` and `optionsList()` to remove the deprecated support for `schema.enumNames`
- Updated the tests accordingly
- Updated `@rjsf/utils` to remove deprecations:
- Removed the deprecated `getMatchingOption()` and `mergeValidationData()` and the matching functions in the `SchemaUtilsType`
- Updated the tests accordingly
- Updated the `ValidatorType` to remove the `toErrorList()` function
- Updated the tests accordingly
- Moved the implementation `getMatchingOption()` into the `getFirstMatchingOption()`
- Updated `@rjsf/validator-ajv8` to remove the `toErrorList()` implementations and tests associated with them
- Updated the `form-props.md` and `utility-functions.md` documentation files to remove deprecation mentions
- Updated the `v6.x upgrade guide.md` to document the deprecations removals
- Updated the `CHANGELOG_v6.md` to document the deprecations removals
# Conflicts:
# packages/docs/docs/migration-guides/v6.x upgrade guide.md
heath-freenome
force-pushed
the
remove-deprecations-and-react-18-min
branch
from
ca955d1 to
f92badc
Compare
nickgros
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
As part of v6 readiness, removed old deprecations and bumped react support to >= 18
package.jsonfiles to change react peer dependency support to>=18Formto remove the deprecatedacceptcharsetSchemaFieldto remove support for the deprecateduiSchema.classNamesBooleanFieldandoptionsList()to remove the deprecated support forschema.enumNames@rjsf/utilsto remove deprecations:getMatchingOption()andmergeValidationData()and the matching functions in theSchemaUtilsTypeValidatorTypeto remove thetoErrorList()functiongetMatchingOption()into thegetFirstMatchingOption()@rjsf/validator-ajv8to remove thetoErrorList()implementations and tests associated with themform-props.mdandutility-functions.mddocumentation files to remove deprecation mentionsv6.x upgrade guide.mdto document the deprecations removalsCHANGELOG_v6.mdto document the deprecations removalsChecklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.