Options to use default React shouldComponentUpdate logic #4702
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbieculkin
changed the title
4 tasks
robbieculkin
changed the title
nickgros
approved these changes
Aug 1, 2025
| const { experimental_componentUpdateStrategy = 'customDeep' } = this.props.registry; | ||
|
|
||
| return shouldRender(this, nextProps, this.state, experimental_componentUpdateStrategy); | ||
| } |
There was a problem hiding this comment.
I hadn't realized that this behavior also applied to SchemaField. Nice catch!
|
@heath-freenome, @nickgros, or another maintainer -- would you mind helping me release this change to npm? I'm looking at the contribution guide and it's not clear to me whether this is a prerelease, custom, or other version given the I've created a release MR here: #4714 |
|
@robbieculkin beta.13 is released |
|
@heath-freenome thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reasons for making this change
Addresses #4690.
React's default
Componentrendering strategy is to re-render on every state change, seeshouldComponentUpdatedocs.PureComponent's strategy uses shallow equality.This PR allows users to select the
shouldRenderReact behavior to be used via a new prop,experimental_componentUpdateStrategy. There are 3 options:customDeep(default): uses RJSF'sdeepEqualsshallow: shallow equalityalways: returns true. component always rerenders.Checklist
npx nx run-many --target=build --exclude=@rjsf/docs && npm run test:updateto update snapshots, if needed.