Skip to content

Commit 33be3ab

Browse files
committed
Remove unused fullDetails prop on status pages
1 parent 11a8115 commit 33be3ab

File tree

5 files changed

+18
-18
lines changed

5 files changed

+18
-18
lines changed

interface/src/containers/APConfiguration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,7 @@ class APConfiguration extends Component {
2929
<Tab value="apStatus" label="AP Status" />
3030
<Tab value="apSettings" label="AP Settings" />
3131
</Tabs>
32-
{selectedTab === "apStatus" && <APStatus fullDetails={true} />}
32+
{selectedTab === "apStatus" && <APStatus />}
3333
{selectedTab === "apSettings" && <APSettings />}
3434
</MenuAppBar>
3535
)

interface/src/containers/APStatus.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ class APStatus extends Component {
5050
return data.active ? "Active" : "Inactive";
5151
}
5252

53-
createListItems(data, fullDetails, classes){
53+
createListItems(data, classes){
5454
return (
5555
<Fragment>
5656
<ListItem>
@@ -83,12 +83,12 @@ class APStatus extends Component {
8383
);
8484
}
8585

86-
renderAPStatus(data, fullDetails, classes){
86+
renderAPStatus(data, classes){
8787
return (
8888
<div>
8989
<List>
9090
<Fragment>
91-
{this.createListItems(data, fullDetails, classes)}
91+
{this.createListItems(data, classes)}
9292
</Fragment>
9393
</List>
9494
<Button variant="contained" color="secondary" className={classes.button} onClick={this.props.loadData}>
@@ -99,7 +99,7 @@ class APStatus extends Component {
9999
}
100100

101101
render() {
102-
const { data, fetched, errorMessage, classes, fullDetails } = this.props;
102+
const { data, fetched, errorMessage, classes } = this.props;
103103

104104
return (
105105
<SectionContent title="AP Status">
@@ -112,7 +112,7 @@ class APStatus extends Component {
112112
</Typography>
113113
</div>
114114
:
115-
data ? this.renderAPStatus(data, fullDetails, classes)
115+
data ? this.renderAPStatus(data, classes)
116116
:
117117
<div>
118118
<Typography variant="display1" className={classes.fetching}>

interface/src/containers/NTPStatus.js

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ class NTPStatus extends Component {
5151
this.props.loadData();
5252
}
5353

54-
createListItems(data, fullDetails, classes){
54+
createListItems(data, classes){
5555
return (
5656
<Fragment>
5757
<ListItem>
@@ -104,11 +104,11 @@ class NTPStatus extends Component {
104104
);
105105
}
106106

107-
renderNTPStatus(data, fullDetails, classes){
107+
renderNTPStatus(data, classes){
108108
return (
109109
<div>
110110
<List>
111-
{this.createListItems(data, fullDetails, classes)}
111+
{this.createListItems(data, classes)}
112112
</List>
113113
<Button variant="contained" color="secondary" className={classes.button} onClick={this.props.loadData}>
114114
Refresh
@@ -118,7 +118,7 @@ class NTPStatus extends Component {
118118
}
119119

120120
render() {
121-
const { data, fetched, errorMessage, classes, fullDetails } = this.props;
121+
const { data, fetched, errorMessage, classes } = this.props;
122122

123123
return (
124124
<SectionContent title="NTP Status">
@@ -131,7 +131,7 @@ class NTPStatus extends Component {
131131
</Typography>
132132
</div>
133133
:
134-
data ? this.renderNTPStatus(data, fullDetails, classes)
134+
data ? this.renderNTPStatus(data, classes)
135135
:
136136
<div>
137137
<Typography variant="display1" className={classes.fetching}>

interface/src/containers/WiFiConfiguration.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class WiFiConfiguration extends Component {
4343
<Tab value="networkScanner" label="Network Scanner" />
4444
<Tab value="wifiSettings" label="WiFi Settings" />
4545
</Tabs>
46-
{selectedTab === "wifiStatus" && <WiFiStatus fullDetails={true} />}
46+
{selectedTab === "wifiStatus" && <WiFiStatus />}
4747
{selectedTab === "networkScanner" && <WiFiNetworkScanner selectNetwork={this.selectNetwork} />}
4848
{selectedTab === "wifiSettings" && <WiFiSettings deselectNetwork={this.deselectNetwork} selectedNetwork={this.state.selectedNetwork} />}
4949
</MenuAppBar>

interface/src/containers/WiFiStatus.js

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ class WiFiStatus extends Component {
5858
return status.dns_ip_1 + (status.dns_ip_2 ? ','+status.dns_ip_2 : '');
5959
}
6060

61-
createListItems(data, fullDetails, classes) {
61+
createListItems(data, classes) {
6262
return (
6363
<Fragment>
6464
<ListItem>
@@ -69,7 +69,7 @@ class WiFiStatus extends Component {
6969
</ListItem>
7070
<Divider variant="inset" component="li" />
7171
{
72-
(fullDetails && isConnected(data)) &&
72+
isConnected(data) &&
7373
<Fragment>
7474
<ListItem>
7575
<Avatar>
@@ -108,11 +108,11 @@ class WiFiStatus extends Component {
108108
);
109109
}
110110

111-
renderWiFiStatus(data, fullDetails, classes) {
111+
renderWiFiStatus(data, classes) {
112112
return (
113113
<div>
114114
<List>
115-
{this.createListItems(data, fullDetails, classes)}
115+
{this.createListItems(data, classes)}
116116
</List>
117117
<Button variant="contained" color="secondary" className={classes.button} onClick={this.props.loadData}>
118118
Refresh
@@ -123,7 +123,7 @@ class WiFiStatus extends Component {
123123
}
124124

125125
render() {
126-
const { data, fetched, errorMessage, classes, fullDetails } = this.props;
126+
const { data, fetched, errorMessage, classes } = this.props;
127127

128128
return (
129129
<SectionContent title="WiFi Status">
@@ -136,7 +136,7 @@ class WiFiStatus extends Component {
136136
</Typography>
137137
</div>
138138
:
139-
data ? this.renderWiFiStatus(data, fullDetails, classes)
139+
data ? this.renderWiFiStatus(data, classes)
140140
:
141141
<div>
142142
<Typography variant="display1" className={classes.fetching}>

0 commit comments

Comments
 (0)